Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move stale yml file to correct dir #49

Merged
merged 1 commit into from
Aug 12, 2020
Merged

ci: move stale yml file to correct dir #49

merged 1 commit into from
Aug 12, 2020

Conversation

feng-tao
Copy link
Member

Signed-off-by: feng-tao fengtao04@gmail.com

Summary of Changes

The pr stale yaml file never works in this repo as it is placed in the wrong dir. Move it to the correct dir.

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@feng-tao
ci: move stale yml file to correct dir
1d80192 
Signed-off-by: feng-tao <fengtao04@gmail.com>
@feng-tao feng-tao requested a review from Golodhros August 12, 2020 06:03
Golodhros
Golodhros approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feng-tao feng-tao merged commit f955d1c into master Aug 12, 2020
@feng-tao feng-tao deleted the tfeng_move_stale branch August 12, 2020 16:08
jerryzhu2007 pushed a commit to kylg/amundsencommon that referenced this pull request Aug 20, 2020
Merge commit 'cdb8028001eaab91bcaf34a6d7b68fc1b318ea5d'
f66023f 
* commit 'cdb8028001eaab91bcaf34a6d7b68fc1b318ea5d':
  chore: move repo references from lyft -> amundsen (amundsen-io#51)
  feat: add github action for test and pypi publish (amundsen-io#47)
  ci: add dependabot config (amundsen-io#50)
  ci: move stale yml file to correct dir (amundsen-io#49)
  ci: test pypi travis setting (amundsen-io#48)
  chore: apply license headers to all the source files (amundsen-io#41)
  Update version to pick up report url changes

# Conflicts:
#	setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feng-tao @Golodhros