Add Worldwide Corporate Information Page content item #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkempster34
force-pushed
the
add-ww-cip-content-item
branch
from
836fa1f
to
e51be2d
Compare
Currently, the corporate information pages associated with worldwide organisations are published as `placeholder` content items. This creates a new content item for them. The existing content item for corpoarate information pages could be used instead. However: - We require a link to the associated `worldwide_organisation`. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in `government-frontend` as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because `government_frontend` maps content items to templates through their `schema_name` (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages.
jkempster34
force-pushed
the
add-ww-cip-content-item
branch
from
e51be2d
to
531f3be
Compare
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 12, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 13, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
jkempster34
added a commit
to alphagov/government-frontend
that referenced
this pull request
Jun 13, 2023
We have added a new content item to represent Corporate Information Pages that are associated with Worldwide Organisations (alphagov/publishing-api#2399). Because the Worldwide Corporate Information Pages have a link to their Worldwide Organisation, much of the rendering code added for Worldwide Offices and Worldwide Organisations works with this page.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 14, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 14, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 14, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
jkempster34
added a commit
to alphagov/government-frontend
that referenced
this pull request
Jun 14, 2023
We have added a new content item to represent Corporate Information Pages that are associated with Worldwide Organisations (alphagov/publishing-api#2399). Because the Worldwide Corporate Information Pages have a link to their Worldwide Organisation, much of the rendering code added for Worldwide Offices and Worldwide Organisations works with this page.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 26, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 26, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 26, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 27, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
brucebolt
added a commit
to alphagov/content-data-api
that referenced
this pull request
Jun 27, 2023
The Worldwide Corporate Information Page schema was added in alphagov/publishing-api#2399. This adds that schema type to this application.
jkempster34
added a commit
to alphagov/government-frontend
that referenced
this pull request
Jun 27, 2023
We have added a new content item to represent Corporate Information Pages that are associated with Worldwide Organisations (alphagov/publishing-api#2399). Because the Worldwide Corporate Information Pages have a link to their Worldwide Organisation, much of the rendering code added for Worldwide Offices and Worldwide Organisations works with this page.
jkempster34
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 28, 2023
Following the work to add a new content item (alphagov/publishing-api#2399) and move over the rendering of the worldwide corporate information pages (alphagov/government-frontend#2824), we can switch the rendering of all of these pages to government-frontend. This includes the "about us" CIPs, which are published as placeholder content items (see #7844), these now show a 404 page as desired.
ryanb-gds
pushed a commit
to alphagov/whitehall
that referenced
this pull request
Jun 28, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
syed-ali-tw
pushed a commit
to alphagov/whitehall
that referenced
this pull request
Jun 28, 2023
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the corporate information pages associated with worldwide
organisations are published as
placeholdercontent items.This creates a new content item for them.
The existing content item for corpoarate information pages could be used
instead. However:
worldwide_organisation. Having a newcontent item means that we don't have to attach multiple optional links to the
corporate information page content item.
government-frontendas theworldwide organisation corporate information pages are quite different when
compared to the organisation corporate information pages. Because
government_frontendmaps content items to templates through theirschema_name(except for a few exceptions), it would make sense to follow thispattern.
needed in order to render the worldwide organisation corporate informaiton pages.
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.