Present worldwide corporate information pages #7789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkempster34
force-pushed
the
ww-org-cips
branch
3 times, most recently
from
ea05431
to
6243032
Compare
jkempster34
force-pushed
the
ww-org-cips
branch
2 times, most recently
from
33fc5bd
to
36c1099
Compare
jkempster34
force-pushed
the
ww-org-cips
branch
7 times, most recently
from
40c2e4d
to
6947a9a
Compare
jkempster34
force-pushed
the
ww-org-cips
branch
3 times, most recently
from
e80bec8
to
58880af
Compare
We have decided to publish the Corporate Information Pages associated with Worldwide Organisations as a separate content item (alphagov/publishing-api#2399) for the following reasons: - We require a link to the associated worldwide_organisation. Having a new content item means that we don't have to attach multiple optional links to the corporate information page content item. - We will need a new template for this page in government-frontend as the worldwide organisation corporate information pages are quite different when compared to the organisation corporate information pages. Because government_frontend maps content items to templates through their schema_name (except for a few exceptions), it would make sense to follow this pattern. - Many of the attributes of the corporate information page schema are not needed in order to render the worldwide organisation corporate informaiton pages. This adds a presenter for the new content item. Any shared attributes are DRYed up through a shared PayloadBuilder.
We have added a new WorldwideCorporateInformationPagePresenter. Present the worldwide corporate information pages via this new presenter unless they are "about us" pages. "about us" worldwide corporate information pages are a special case. We want to publish these as `placeholder` content items with a unique base path (see #7844).
Currently, Organisations are republished when a related Corporate Information Pages changes, but Worldwide Organisations are not. Now that we publish Worldwide Corporate Information Pages, we want to change this. This is important because the Worldwide Organisation content item surfaces information about related Corporate Information Pages on it's `details` rather than it's `links` (though the links are present as well, they aren't used. This is consistent with the Organisation content item).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/ATDZQXqq
Add presenter for worldwide corporate information pages
We have decided to publish the Corporate Information Pages associated with
Worldwide Organisations as a separate content item
(alphagov/publishing-api#2399) for the following
reasons:
content item means that we don't have to attach multiple optional links to the
corporate information page content item.
worldwide organisation corporate information pages are quite different when
compared to the organisation corporate information pages. Because
government_frontend maps content items to templates through their
schema_name (except for a few exceptions), it would make sense to follow this
pattern.
needed in order to render the worldwide organisation corporate informaiton
pages.
This adds a presenter for the new content item. Any shared attributes are DRYed
up through a shared PayloadBuilder.
Publish worldwide corporate information pages via their own presenter
We have added a new WorldwideCorporateInformationPagePresenter.
Present the worldwide corporate information pages via this new presenter unless
they are "about us" pages.
"about us" worldwide corporate information pages are a special case. We want to
publish these as
placeholdercontent items with a unique base path (see#7844).
Republish Worldwide Organisation on Corporate Information Pages changes
Currently, Organisations are republished when a related Corporate Information
Pages changes, but Worldwide Organisations are not. Now that we publish
Worldwide Corporate Information Pages, we want to change this.
This is important because the Worldwide Organisation content item surfaces
information about related Corporate Information Pages on it's
detailsratherthan it's
links(though the links are present as well, they aren't used. Thisis consistent with the Organisation content item).
Follow these steps if you are doing a Rails upgrade.