Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the rendering of worldwide CIPs to government-frontend #7867

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

jkempster34
Copy link
Contributor

@jkempster34 jkempster34 commented Jun 28, 2023

https://trello.com/c/RbQUlEqp

Following the work to add a new content item
(alphagov/publishing-api#2399) and move over the
rendering of the worldwide corporate information pages
(alphagov/government-frontend#2824), we can switch the
rendering of all of these pages to government-frontend.

This includes the "about us" CIPs, which are published as placeholder content
items (see #7844), these now show a 404 page as desired.


⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@jkempster34 jkempster34 marked this pull request as ready for review June 28, 2023 13:05
Following the work to add a new content item
(alphagov/publishing-api#2399) and move over the
rendering of the worldwide corporate information pages
(alphagov/government-frontend#2824), we can switch the
rendering of all of these pages to government-frontend.

This includes the "about us" CIPs, which are published as placeholder content
items (see #7844), these now show a 404 page as desired.
Copy link
Member

@brucebolt brucebolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jkempster34 jkempster34 merged commit 9755b60 into main Jun 29, 2023
8 checks passed
@jkempster34 jkempster34 deleted the switch-rendering-ww-cips branch June 29, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants