Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation gets clipped when view has a fixed size #161

Closed
gpeal opened this issue Feb 24, 2017 · 4 comments
Closed

Animation gets clipped when view has a fixed size #161

gpeal opened this issue Feb 24, 2017 · 4 comments
Assignees
@gpeal

Comments

@gpeal
Copy link
Collaborator

gpeal commented Feb 24, 2017

Requires more investigation. Likely due to masks/mattes + saveLayer/drawBitmap.

@qmetzler-luna
@gpeal gpeal self-assigned this Feb 24, 2017
@gpeal gpeal mentioned this issue Feb 24, 2017
Closed
@gpeal
Copy link
Collaborator Author

gpeal commented Feb 26, 2017

@qmetzler-luna I know what's going on. You can work around this by changing your composition size to the display size you want. The composition size in px will be natively converted to dp when rendered so change your composition to be 75px.

gpeal pushed a commit that referenced this issue Feb 28, 2017
Fix multiple masks
0808f2d 
They broke because masks were getting applied iteratively instead
of together.

Fixes #161
@gpeal gpeal closed this as completed Feb 28, 2017
@gpeal
Copy link
Collaborator Author

gpeal commented Feb 28, 2017

This will be released with 1.5.2

@gpeal gpeal mentioned this issue Feb 28, 2017
Merged
@qmetzler-luna
Copy link

@gpeal Thanks, it's working a lot better but if I downsize too much I'm still having some issue
see attached with 45dp for example.
analytics.aep.zip

gpeal added a commit that referenced this issue Feb 28, 2017
@gpeal
More masks and matte improvements (#169)
a83c26a 
Uses multiple levels of offscreen buffers instead of a bitmap to further improve mask and matte performance. There are now no bitmaps created for masks or mattes! Performance is comparable but memory is greatly reduced.

Multiple masks were broken because they were applied sequentially rather than together. Fixes #161.
@gpeal
Copy link
Collaborator Author

gpeal commented Mar 1, 2017

@qmetzler-luna I just released 1.5.2 which is definitely an improvement with your samples. Thanks for sending them by the way.
Analytics is still not matting perfectly because you have visible matte layers. Can you try altering your animation so that matte layers don't need to be visible?

gpeal pushed a commit that referenced this issue Jul 27, 2017
Allow animations with masks and mattes to scale up
fcdac57 
Previously, animations were given a max scale due to saveLayer,
which is used for mattes and masks, only saving the canvas size.
This is problematic when the scale makes the animations larger
than the view because the masks and mattes get clipped. This gets
around that by scaling up the animation up until the size of the
view then scaling the canvas with the remaining scale.

#395 #301 #161 #326 #315
Fixes #404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpeal gpeal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpeal @qmetzler-luna