-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-composition support #61
Comments
We don't support precomps yet but it's something I'm very actively looking into adding! Stay tuned! |
This adds initial precomp support. It works for most relatively simple precomps including precomps with parent layers but doesn't yet support masks, mattes, or start delays. #61
Still not fully working for my animation but I can definitely see some improvement. Do I still need to wait for the support of something more or is it related? adin.zip |
@qmetzler-luna You'll have to checkout the repo and rebase to check the latest change. |
@qmetzler-luna @stewjacks 1.5.0 is now out! |
@gpeal Awesome! I'll play with it today ✌️ |
@qmetzler-luna yeah I think there may still be a few minor things. I have your AE file though so I'll continue to use it as a benchmark. @stewjacks Great, if you have any issues, can you send me your AE file at lottie@airbnb.com? |
@gpeal lots of my animation are working smoothly, thanks for the update. One does not work at all, I'll send it to you tomorrow. |
@qmetzler-luna Can you send me one where only the top left animates correctly? |
@gpeal actually the one I sent you is doing it |
@gpeal Here are three aep files samples of the one not fully working for me. Appart from the top left issue that they all have, "atom.aep" has some masking issue I suppose (I have several animation with the same issue), "car.aep" has the wheels not animating and "stadium.aep" isn't working at all but bodymovin can't make it work either. |
Hi @qmetzler-luna there are a couple of things in your files that i've noticed that we're still currently working on. Atom.aep - we dont yet fully support fill rules. So instead of the multiple paths being cut through they just get added. Car.aep - Neither bodymovin nor Lottie supports layer styles at the moment Also you're using some expressions in ehre that Lottie doesnt yet support Stadium.aep file. Neither Bodymovin nor Lottie supports layer styles at the moment. You can achieve that same stroke by just using a stroke inside the shape layer |
This seems to be working for me. We originally had issues with assets exported from Illustrator, but we've been going through and deleting merge paths as well as all the random groups created when importing... and everything seems to be honky dory now. Thanks! |
@qmetzler-luna track #158 for fill types |
@therealsalih Thanks for the precision! @gpeal And for the size of the animations? You can test it by setting 75dp instead of wrap_content in the demo project and load the first animation I sent you. |
@qmetzler-luna I can see your issue. I'll investigate it and track the progress in #161 |
@gpeal For some reason, I can't get a pre-comp to work in my file. It exports from after effects fine but doesn't show up in ios |
@fentonbutcher Can you post the issue on lottie-ios then? |
Quite a few of our animations are pre-comp'd as we reuse elements. Bodymovin supports them; Am I doing something wrong and/or is this on the roadmap for Lottie? I'm game to look into it.
The text was updated successfully, but these errors were encountered: