Pre-composition support

[stewjacks]

Quite a few of our animations are pre-comp'd as we reuse elements. Bodymovin supports them; Am I doing something wrong and/or is this on the roadmap for Lottie? I'm game to look into it.

[gpeal]

We don't support precomps yet but it's something I'm very actively looking into adding! Stay tuned!

[qmetzler-luna]

Still not fully working for my animation but I can definitely see some improvement. Do I still need to wait for the support of something more or is it related?
(I paid a set of animation so I don't really know how they're done.)

adin.zip
(rename adin.zip into adin.aep)

[gpeal]

@qmetzler-luna You'll have to checkout the repo and rebase to check the latest change.
I'm actually using yours as a test for some things right now. There are a few reasons yours still isn't working but I hope to get to them soon. Stay tuned.

[gpeal]

@qmetzler-luna @stewjacks 1.5.0 is now out!

[stewjacks]

@gpeal Awesome! I'll play with it today ✌️

[gpeal]

@qmetzler-luna yeah I think there may still be a few minor things. I have your AE file though so I'll continue to use it as a benchmark.

@stewjacks Great, if you have any issues, can you send me your AE file at lottie@airbnb.com?

[qmetzler-luna]

@gpeal lots of my animation are working smoothly, thanks for the update. One does not work at all, I'll send it to you tomorrow.
But for all of them if I use let say 75dp as height and width instead of wrap_content only the top left part seems to animate correctly.

[gpeal]

@qmetzler-luna Can you send me one where only the top left animates correctly?
My screenshot tests seem to be doing that but I haven't actually seen that happen on a device so I'd like to figure out what's going on there.

[qmetzler-luna]

@gpeal actually the one I sent you is doing it

[qmetzler-luna]

@gpeal Here are three aep files samples of the one not fully working for me. Appart from the top left issue that they all have, "atom.aep" has some masking issue I suppose (I have several animation with the same issue), "car.aep" has the wheels not animating and "stadium.aep" isn't working at all but bodymovin can't make it work either.
lottie.zip

[therealsalih]

Hi @qmetzler-luna there are a couple of things in your files that i've noticed that we're still currently working on.

Atom.aep - we dont yet fully support fill rules. So instead of the multiple paths being cut through they just get added.

Car.aep - Neither bodymovin nor Lottie supports layer styles at the moment

Also you're using some expressions in ehre that Lottie doesnt yet support

Stadium.aep file. Neither Bodymovin nor Lottie supports layer styles at the moment. You can achieve that same stroke by just using a stroke inside the shape layer

[stewjacks]

This seems to be working for me. We originally had issues with assets exported from Illustrator, but we've been going through and deleting merge paths as well as all the random groups created when importing... and everything seems to be honky dory now. Thanks!

[gpeal]

@qmetzler-luna track #158 for fill types
@stewjacks Great to hear!

[qmetzler-luna]

@therealsalih Thanks for the precision! @gpeal And for the size of the animations? You can test it by setting 75dp instead of wrap_content in the demo project and load the first animation I sent you.

[gpeal]

@qmetzler-luna I can see your issue. I'll investigate it and track the progress in #161

[fentonbutcher]

@gpeal For some reason, I can't get a pre-comp to work in my file. It exports from after effects fine but doesn't show up in ios

[gpeal]

@fentonbutcher Can you post the issue on lottie-ios then?