Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: sp-action-menu forces quiet mode #3040

Closed
1 task done
benjamind opened this issue Mar 17, 2023 · 0 comments · Fixed by #3041
Closed
1 task done

[Bug]: sp-action-menu forces quiet mode #3040

benjamind opened this issue Mar 17, 2023 · 0 comments · Fixed by #3041
Labels
bug Something isn't working triage An issue needing triage

Comments

@benjamind
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-action-menu

Expected behavior

quiet defaults to false

Actual behavior

quiet is forced to true

Screenshots

No response

What browsers are you seeing the problem in?

Firefox, Chrome, Safari, Microsoft Edge

How can we reproduce this issue?

  1. Go to '...' and notice that even though quiet is not set in the examples it is defaulting to true

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response
@benjamind benjamind added bug Something isn't working triage An issue needing triage labels Mar 17, 2023
benjamind added a commit that referenced this issue Mar 17, 2023
@benjamind
fix: sets action-menu quiet to false by default, fixes #3040
1bf6589
@benjamind benjamind mentioned this issue Mar 17, 2023
Merged
13 tasks
benjamind added a commit that referenced this issue Mar 17, 2023
@benjamind
feat: sets action-menu quiet to false by default, fixes #3040
680d23d
benjamind added a commit that referenced this issue Mar 17, 2023
@benjamind
feat: sets action-menu quiet to false by default, fixes #3040
001e71c
Westbrook pushed a commit that referenced this issue Mar 22, 2023
@benjamind
feat: sets action-menu quiet to false by default, fixes #3040
46c860c
Westbrook pushed a commit that referenced this issue Mar 22, 2023
@benjamind @Westbrook
feat: sets action-menu quiet to false by default, fixes #3040
8414cab
jianliao pushed a commit that referenced this issue Mar 23, 2023
@benjamind @jianliao
feat: sets action-menu quiet to false by default, fixes #3040
56a02e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage An issue needing triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sets action-menu quiet to false by default, fixes #3040 adobe/spectrum-web-components
1 participant
@benjamind