fix: sets action-menu quiet to false by default, fixes #3040

adobe · Mar 17, 2023 · 1bf6589 · 1bf6589
1 parent f6a7ece
commit 1bf6589
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/action-menu/src/ActionMenu.ts b/packages/action-menu/src/ActionMenu.ts
@@ -62,7 +62,7 @@ export class ActionMenu extends ObserveSlotText(PickerBase, 'label') {
     protected override render(): TemplateResult {
         return html`
             <sp-action-button
-                quiet
+                ?quiet=${this.quiet}
                 ?selected=${this.open}
                 aria-haspopup="true"
                 aria-controls="popover"
@@ -85,7 +85,6 @@ export class ActionMenu extends ObserveSlotText(PickerBase, 'label') {
         if (changedProperties.has('invalid')) {
             this.invalid = false;
         }
-        this.quiet = true;
         super.update(changedProperties);
     }
 }
diff --git a/packages/picker/src/Picker.ts b/packages/picker/src/Picker.ts
@@ -360,9 +360,6 @@ export class PickerBase extends SizedMixin(Focusable) {
             popover.style.setProperty('--swc-menu-width', `100%`);
             return;
         }
-        if (this.quiet) return;
-        // only use `this.offsetWidth` when Standard variant
-        popover.style.setProperty('min-width', `${this.offsetWidth}px`);
     }
 
     private async closeMenu(): Promise<void> {
@@ -637,6 +634,14 @@ export class Picker extends PickerBase {
         return [pickerStyles, chevronStyles];
     }
 
+    protected override sizePopover(popover: HTMLElement): void {
+        super.sizePopover(popover);
+
+        if (this.quiet) return;
+        // only use `this.offsetWidth` when Standard variant
+        popover.style.setProperty('min-width', `${this.offsetWidth}px`);
+    }
+
     protected override onKeydown = (event: KeyboardEvent): void => {
         const { code } = event;
         this.focused = true;