fix: sets action-menu quiet to false by default, fixes #3040

[benjamind]

Description

• Modified PickerBase to no longer force divergent behavior on quiet attribute in sizePopover, moved this logic down into Picker.
• Modified ActionMenu to reflect its quiet property down onto the internal action-button, and no longer force its value to true.

NOTE: This is a breaking change, as the default behavior for sp-action-menu will now be noisy rathern than quiet.

Related issue(s)

Fixes #3040

Motivation and context

How has this been tested?

• Test case 1
  1. Go here
  2. Do this
• Test case 2
  1. Go here
  2. Do this

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• If my change required a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

[github-actions]

Branch Preview

• Documentation Site
• Storybook

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• High Contrast Mode | Medium | LTR
• Classic | Lightest | Medium | LTR
• Classic | Lightest | Medium | RTL
• Classic | Lightest | Large | LTR
• Classic | Lightest | Large | RTL
• Classic | Light | Medium | LTR
• Classic | Light | Medium | RTL
• Classic | Light | Large | LTR
• Classic | Light | Large | RTL
• Classic | Dark | Medium | LTR
• Classic | Dark | Medium | RTL
• Classic | Dark | Large | LTR
• Classic | Dark | Large | RTL
• Classic | Darkest | Medium | LTR
• Classic | Darkest | Medium | RTL
• Classic | Darkest | Large | LTR
• Classic | Darkest | Large | RTL
• Express | Lightest | Medium | LTR
• Express | Lightest | Medium | RTL
• Express | Lightest | Large | LTR
• Express | Lightest | Large | RTL
• Express | Light | Medium | LTR
• Express | Light | Medium | RTL
• Express | Light | Large | LTR
• Express | Light | Large | RTL
• Express | Dark | Medium | LTR
• Express | Dark | Medium | RTL
• Express | Dark | Large | LTR
• Express | Dark | Large | RTL
• Express | Darkest | Medium | LTR
• Express | Darkest | Medium | RTL
• Express | Darkest | Large | LTR
• Express | Darkest | Large | RTL

[Westbrook]

This looks great. Can you do the quick favor of editing the commit from fix: to feat: to it amounts to the breaking change it is meant to be when publication time comes next week?

[Westbrook]

Look CI is also telling us it's a breaking change. It's so nice when computers actually works in ways that prevent humans from making mistakes. Would be nice if you were to drop in some a new quiet demo or two for Storybook/CI, but we can always follow up on that later. We will need the VRTs bumped, as outlined in https://github.com/adobe/spectrum-web-components/tree/lightningcss#keeping-ci-assets-updated

[github-actions]

Tachometer results

Chrome

action-menu permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	648 kB	245.05ms - 249.57ms	-	unsure 🔍 -0% - +2% -0.24ms - +5.41ms
branch	646 kB	243.03ms - 246.42ms	unsure 🔍 -2% - +0% -5.41ms - +0.24ms	-

card permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	433 kB	98.42ms - 100.96ms	-	slower ❌ 0% - 3% 0.04ms - 2.99ms
branch	435 kB	97.42ms - 98.93ms	faster ✔ 0% - 3% 0.04ms - 2.99ms	-

picker permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	501 kB	777.37ms - 793.87ms	-	unsure 🔍 -1% - +2% -5.94ms - +14.73ms
branch	499 kB	775.00ms - 787.45ms	unsure 🔍 -2% - +1% -14.73ms - +5.94ms	-

split-button permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	580 kB	2037.50ms - 2041.05ms	-	unsure 🔍 -0% - +0% -1.02ms - +3.80ms
branch	578 kB	2036.25ms - 2039.52ms	unsure 🔍 -0% - +0% -3.80ms - +1.02ms	-

top-nav permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	363 kB	119.53ms - 122.17ms	-	faster ✔ 1% - 4% 0.90ms - 5.04ms
branch	365 kB	122.23ms - 125.42ms	slower ❌ 1% - 4% 0.90ms - 5.04ms	-

Firefox

action-menu permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	648 kB	389.22ms - 399.54ms	-	unsure 🔍 -1% - +3% -4.52ms - +10.12ms
branch	646 kB	386.38ms - 396.78ms	unsure 🔍 -3% - +1% -10.12ms - +4.52ms	-

card permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	433 kB	159.82ms - 169.06ms	-	unsure 🔍 -2% - +5% -3.38ms - +8.22ms
branch	435 kB	158.52ms - 165.52ms	unsure 🔍 -5% - +2% -8.22ms - +3.38ms	-

picker permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	501 kB	1025.00ms - 1035.20ms	-	unsure 🔍 -0% - +1% -4.13ms - +9.45ms
branch	499 kB	1022.96ms - 1031.92ms	unsure 🔍 -1% - +0% -9.45ms - +4.13ms	-

split-button permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	580 kB	2151.17ms - 2161.11ms	-	unsure 🔍 -0% - +0% -5.25ms - +7.81ms
branch	578 kB	2150.63ms - 2159.09ms	unsure 🔍 -0% - +0% -7.81ms - +5.25ms	-

top-nav permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	363 kB	221.08ms - 230.44ms	-	unsure 🔍 -4% - +1% -9.56ms - +2.80ms
branch	365 kB	225.11ms - 233.17ms	unsure 🔍 -1% - +4% -2.80ms - +9.56ms	-

[Westbrook]

Thanks for getting into all the documentation and story changes for this! Cleaned up the one test that no longer applied and cycled the VRTs based on this change. Going out later today, or so 🤞🏼