Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image replacement title property is not output by the pipeline #308

Closed
tmaret opened this issue May 5, 2023 · 5 comments · Fixed by #312
Closed

Image replacement title property is not output by the pipeline #308

tmaret opened this issue May 5, 2023 · 5 comments · Fixed by #312
Labels
bug Something isn't working released

Comments

@tmaret
Copy link
Contributor

tmaret commented May 5, 2023

Description

Alternative title is not output by the pipeline although it is set properly on an image located inside a word document.

Alternative description is output properly as alt attribute on the img tag.

To Reproduce
Steps to reproduce the behavior:

  1. Create a word document in Sharepoint
  2. Add an image in the document
  3. Set the alternative title to "I went through the pipeline"
  4. Preview the document
  5. Render the document as .md and find the title "I went through the pipeline" in the output
  6. Render the document as HTML and see that the title is not in the output

If you can access it, you may also use this word document

Expected behavior

I expect the replacement title value set on an image within a word document to be output as title attribute on the img tag.

Screenshots

The following screenshot shows the alternative title and descriptions set on an image in within a word document

alternative

The following screenshot shows the Markdown output of the document that contains the image. The alternative title is present in the output, as expected.

md-fine

The following screenshot shows that the alternative title is not contained in the HTML output.

Screenshot 2023-05-05 at 21 12 37

Version:
14.21.2

Additional context

https://cq-dev.slack.com/archives/C04RN3CQWBZ/p1683295645721079?thread_ts=1683295547.817699&cid=C04RN3CQWBZ

@tmaret
Copy link
Contributor Author

tmaret commented May 12, 2023

Added a failing test case in main...tmaret:helix-html-pipeline:issue-308

@tmaret
Copy link
Contributor Author

tmaret commented May 12, 2023

Opened a PR with the fix and test #312

@tripodsan
Copy link
Contributor

@tmaret what is the use case ?

@tmaret
Copy link
Contributor Author

tmaret commented May 15, 2023

@tripodsan zeiss.[com|de] sets alt and title attributes on img tags. We are porting the news section to Franklin and thus would like to have support for both. Use case is also to close the loop, indeed the Franklin importer supports both attributes but the helix-html-pipeline only supports alt atm.

tripodsan pushed a commit that referenced this issue Jun 1, 2023
github-actions bot pushed a commit that referenced this issue Jun 1, 2023
## [3.11.10](v3.11.9...v3.11.10) (2023-06-01)

### Bug Fixes

* coverage ([#326](#326)) ([31a34b9](31a34b9))
* output image title attribute ([3893776](3893776)), closes [#308](#308)
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

🎉 This issue has been resolved in version 3.11.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants