Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: output image title attribute #312

Merged
merged 7 commits into from
Jun 1, 2023
Merged

fix: output image title attribute #312

merged 7 commits into from
Jun 1, 2023

Conversation

tmaret
Copy link
Contributor

@tmaret tmaret commented May 12, 2023

fix #308

@tmaret tmaret mentioned this pull request May 12, 2023
Closed
@tripodsan tripodsan requested a review from davidnuescheler May 12, 2023 21:55
@tmaret @tripodsan
Update src/steps/create-pictures.js
7668582 
Co-authored-by: Tobias Bocanegra <tripod@bocanegra.ch>
@tmaret
Copy link
Contributor Author

tmaret commented May 31, 2023

Thanks @tripodsan ! I merged your suggestion commit.

@tmaret
Copy link
Contributor Author

tmaret commented May 31, 2023

@tripodsan thanks for point this out, I have pushed commits that include the data-title attribute in test fixtures.

tripodsan
tripodsan requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid empty string attributes

test/fixtures/content/image-from-meta.html Outdated Show resolved Hide resolved
@tmaret @tripodsan
Update src/steps/create-pictures.js
f2dbab9 
Co-authored-by: Tobias Bocanegra <tripod@bocanegra.ch>
@tmaret
Copy link
Contributor Author

tmaret commented Jun 1, 2023

Pfew, done!

@tmaret tmaret mentioned this pull request Jun 1, 2023
Open
@tripodsan tripodsan merged commit 3893776 into adobe:main Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

🎉 This PR is included in version 3.11.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidnuescheler davidnuescheler davidnuescheler approved these changes

@tripodsan tripodsan tripodsan approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image replacement title property is not output by the pipeline
3 participants
@tmaret @tripodsan @davidnuescheler