Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt-text and alt-description specified on images should appear in markup #115

Closed
sdmcraft opened this issue Apr 18, 2023 · 5 comments · Fixed by #200 or #224
Closed

alt-text and alt-description specified on images should appear in markup #115

sdmcraft opened this issue Apr 18, 2023 · 5 comments · Fixed by #200 or #224
Assignees
Milestone

Comments

@sdmcraft
Copy link
Contributor

alt-text and alt-description specified on images in the word doc should should appear in the markup of the page generated for that word doc.

@sdmcraft sdmcraft added this to the UAT Ready milestone Apr 18, 2023
@sdmcraft sdmcraft self-assigned this Apr 18, 2023
@tmaret
Copy link
Contributor

tmaret commented Apr 20, 2023

@sdmcraft do you mean the alt resp. title attributes are missing in images and should be populated from content?

@sdmcraft sdmcraft modified the milestones: UAT Ready, Sprint 3 Apr 27, 2023
@tmaret tmaret assigned tmaret and unassigned sdmcraft May 3, 2023
@tmaret tmaret mentioned this issue May 4, 2023
@sdmcraft
Copy link
Contributor Author

sdmcraft commented May 5, 2023

@tmaret , I see a difference between the alt that we have on this page from the original:
https://www.zeiss.de/semiconductor-manufacturing-technology/news-und-events/smt-pressemeldung/zeiss-trumpf-und-fraunhofer-mit-deutschem-zukunftspreis-ausgezeichnet.html
https://main--zeiss--hlxsites.hlx.live/de/semiconductor-manufacturing-technology/news-und-events/smt-pressemeldung/zeiss-trumpf-und-fraunhofer-mit-deutschem-zukunftspreis-ausgezeichnet
Not sure if I am missing something here.

While the original seems to be fetching from the text in the hero block, we are picking from the text specified with the carousal image. We can check about what's the expectation here as in is there a set of rules behind what becomes the images alt-text. If yes, we can implement those rules else the simplest option is to let the authors specify the alt-text on the image itself and we just use that.

@sdmcraft sdmcraft reopened this May 5, 2023
@tmaret
Copy link
Contributor

tmaret commented May 5, 2023

@sdmcraft https://github.com/adobe/helix-md2docx/issues/255 has been fixed meanwhile and should enable us to provide the same alt attribute.

@tmaret
Copy link
Contributor

tmaret commented May 5, 2023

Ah, also my changes got reverted with this commit 25fe786

@tmaret
Copy link
Contributor

tmaret commented May 8, 2023

Support for title attribute requires adobe/helix-html-pipeline#308

@sdmcraft sdmcraft modified the milestones: Sprint 3, Sprint 4 May 15, 2023
@sdmcraft sdmcraft assigned sdmcraft and unassigned tmaret May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants