Add fallback value for payeename: 'undefined' - CBC Bank

[MMichotte]

Similarly to PR#533, this fix provides a default fallback payeename value ('undefined') for the CBC bank in case the payeename is missing.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	241f78a
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67b0d27ad9780b0008724318
😎 Deploy Preview	https://deploy-preview-4384.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Walkthrough

The change updates the normalizeTransaction method by modifying how the payeeName property is assigned for both positive and negative transaction amounts. For positive amounts, the assignment now includes an additional fallback value of 'undefined', ensuring that if both transaction.debtorName and transaction.remittanceInformationUnstructured are falsy, payeeName will receive the string 'undefined'. A similar modification was made for negative amounts, where the assignment also includes 'undefined' as a fallback if both transaction.creditorName and the result from extractPayeeNameFromRemittanceInfo are falsy. The overall control flow and error handling of the method remain unchanged, and no alterations were made to the declarations of exported or public entities.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64282fd and 241f78a.

📒 Files selected for processing (1)

• packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: build (macos-latest)
• GitHub Check: Wait for Netlify build to finish
• GitHub Check: build (windows-latest)
• GitHub Check: Build Docker image (alpine)
• GitHub Check: Analyze
• GitHub Check: build (ubuntu-latest)
• GitHub Check: Build Docker image (ubuntu)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js (2)

18-21: LGTM! Consider improving the fallback value.

The implementation correctly handles missing payee names for positive amounts. However, using 'undefined' as a string literal could be confusing.

Consider using a more descriptive fallback value:

-        'undefined';
+        'Unknown Payee';

---

18-21: Consider applying the same extraction logic for positive amounts.

For negative amounts, you're using extractPayeeNameFromRemittanceInfo to parse the payee name from the remittance information. Consider applying the same logic to positive amounts for consistency.

Here's a suggested implementation:

     if (Number(transaction.transactionAmount.amount) > 0) {
       editedTrans.payeeName =
         transaction.debtorName ||
-        transaction.remittanceInformationUnstructured ||
-        'undefined';
+        extractPayeeNameFromRemittanceInfo(
+          transaction.remittanceInformationUnstructured,
+          ['Paiement', 'Domiciliation', 'Transfert', 'Ordre permanent'],
+        ) ||
+        'Unknown Payee';

Also applies to: 23-28

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9fd0042 and 64282fd.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/4384.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js (2)

Learnt from: matt-fidd
PR: actualbudget/actual#4253
File: packages/sync-server/src/app-gocardless/banks/easybank_bawaatww.js:24-30
Timestamp: 2025-02-12T01:17:09.971Z
Learning: In bank sync implementations, payeeName is not a core field and should be assigned to editedTrans rather than directly modifying the transaction object, as it's handled by the fallback normalization logic.

Learnt from: matt-fidd
PR: actualbudget/actual#4253
File: packages/sync-server/src/app-gocardless/banks/integration-bank.js:68-71
Timestamp: 2025-02-11T17:28:02.196Z
Learning: In the integration-bank.js normalizeTransaction method, mutating the original transaction object by adding remittanceInformationUnstructuredArrayString and remittanceInformationStructuredArrayString properties is acceptable.

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: Functional
• GitHub Check: Visual regression
• GitHub Check: build (windows-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: Build Docker image (alpine)
• GitHub Check: Build Docker image (ubuntu)