📚 Translation batch #1 #4408
📚 Translation batch #1 #4408
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
WalkthroughThis pull request introduces extensive internationalization updates across various components in the desktop and mobile clients. The changes systematically replace hardcoded text strings with translatable elements by integrating the Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (6)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (2)
packages/desktop-client/src/components/modals/manager/ImportModal.tsx (1)
16-23: 🛠️ Refactor suggestionInternationalize error messages.
The error messages in the
getErrorMessagefunction are hardcoded and not internationalized. For consistency with the rest of the translation effort, these messages should use the translation function.Apply this diff to internationalize the error messages:
function getErrorMessage(error: 'not-ynab4' | boolean) { switch (error) { case 'not-ynab4': - return 'This file is not valid. Please select a .ynab4 file'; + return t('This file is not valid. Please select a .ynab4 file'); default: - return 'An unknown error occurred while importing. Please report this as a new issue on GitHub.'; + return t('An unknown error occurred while importing. Please report this as a new issue on GitHub.'); } }packages/desktop-client/src/components/reports/ReportSidebar.tsx (1)
522-522: 🛠️ Refactor suggestionAdd translations for date range labels.
The "From:" and "To:" labels in the date range selector should be translated using the
t()function.- From: + {t('From:')}- To: + {t('To:')}Also applies to: 554-554
🧹 Nitpick comments (10)
packages/desktop-client/src/components/reports/reports/Spending.tsx (1)
479-486: Consider consolidating similar translation keys.The spending labels use translation with interpolation, which is good. However, there are multiple similar translation keys that could be consolidated:
Spent {{monthYearFormatted}} {{MTD}}is used twiceSpent Average {{monthYearFormatted}} {{MTD}}follows a similar patternConsider consolidating these into a single translation key with an additional parameter:
-{t('Spent {{monthYearFormatted}} {{MTD}}', { +{t('{{type}} {{monthYearFormatted}} {{MTD}}', { + type: isAverage ? t('Spent Average') : t('Spent'), monthYearFormatted: monthUtils.format(compare, 'MMM, yyyy'), MTD: compare === monthUtils.currentMonth(), })}This approach:
- Reduces the number of translation keys
- Makes it easier for translators to maintain consistency
- Follows the DRY principle
Also applies to: 505-511, 531-531, 551-557
packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (1)
753-754: Consider using consistent translation method.While the translation implementation is correct, there's an inconsistency in the approach:
- Some text uses
<Trans>component (e.g., "Select account", "Add transaction")- Some text uses
t()function (here with "New Transaction" and "Transaction")Consider using one consistent method throughout the file for better maintainability.
packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx (1)
321-324: Improve plural handling using i18n.The plural form text should use proper internationalization to handle pluralization across different languages.
Apply this diff to improve plural handling:
- <Text style={styles.mediumText}> - {selectedTransactions.size}{' '} - {isMoreThanOne ? 'transactions' : 'transaction'} selected - </Text> + <Text style={styles.mediumText}> + <Trans + count={selectedTransactions.size} + > + {{ count: selectedTransactions.size }} transaction selected + </Trans> + </Text>packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (1)
491-497: Consider using structured translation keys.While the current implementation works, consider using a more structured approach for translation keys. This helps with maintainability and makes it easier to track translations.
Example approach:
- message: t( - `Covered {{toCategoryName}} overspending from {{fromCategoryName}}.`, - { - toCategoryName: category.name, - fromCategoryName: categoriesById[fromCategoryId].name, - }, - ), + message: t( + 'budget.category.cover_overspending', + { + toCategoryName: category.name, + fromCategoryName: categoriesById[fromCategoryId].name, + }, + ),packages/desktop-client/src/components/reports/ReportSidebar.tsx (1)
384-400: Consider reusing the translated text to avoid duplication.The tooltip text is a slight variation of the menu item text, which could lead to inconsistencies in translations. Consider reusing the translated text to maintain consistency.
- text: t('Include current {{reportOptionRangeType}}', { + const includeCurrentText = t('Include current {{reportOptionRangeType}}', { reportOptionRangeType: ( ReportOptions.dateRangeType.get( customReportItems.dateRange, ) || '' ).toLowerCase(), - }), + }); + text: includeCurrentText, tooltip: t( - 'Include current {{reportOptionRangeType}} in live range', + '{{text}} in live range', { - reportOptionRangeType: ( - ReportOptions.dateRangeType.get( - customReportItems.dateRange, - ) || '' - ).toLowerCase(), + text: includeCurrentText, }, ),packages/desktop-client/src/components/mobile/MobileNavTabs.tsx (2)
95-95: Consider template literals for "Soon" suffix.While the translation implementation is correct, consider using template literals for tabs with the "Soon" suffix to allow more flexible translations in different languages where the word order might vary.
Example for Schedules:
- name: t('Schedules (Soon)'), + name: t('{{name}} (Soon)', { name: t('Schedules') }),Also applies to: 101-101, 107-107, 113-113, 119-119, 125-125, 131-131, 137-137
198-214: Add translation for navigation ARIA label.The navigation role is set but its accessibility label could be translated.
<animated.div - role="navigation" + role="navigation" + aria-label={t('Mobile navigation')} {...bind()}packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx (1)
8-8: Use t() interpolation instead of template literal.While the translation implementation works, using t()'s built-in interpolation would be more idiomatic.
- searchPlaceholder={`${t('Search')} ${accountName}`} + searchPlaceholder={t('Search {{accountName}}', { accountName })}Also applies to: 234-234, 345-345
packages/desktop-client/src/components/reports/reports/CustomReport.tsx (1)
711-713: Simplify nested Trans components.The nested Trans components are unnecessary here and the space after the colon could be part of the translation string.
- <Text> - <Trans>Custom Report:</Trans> - </Text>{' '} + <Text> + <Trans>Custom Report: </Trans> + </Text>packages/desktop-client/src/components/settings/Export.tsx (1)
62-67: Consider using translation keys for technical terms.While the
Transcomponent usage is correct, consider extracting technical terms like "db.sqlite", "metadata.json", and "Import file" into separate translation keys. This allows translators to handle these terms consistently across different languages and contexts.Example refactor:
<Trans> - <strong>Export</strong> your data as a zip file containing{' '} - <code>db.sqlite</code> and <code>metadata.json</code> files. It can be - imported into another Actual instance by closing an open file (if - any), then clicking the "Import file" button, then choosing "Actual." + <strong>{t('export')}</strong> {t('export.instructions.part1')}{' '} + <code>{t('technical.dbfile')}</code> {t('and')} <code>{t('technical.metafile')}</code> {t('export.instructions.part2')} + {t('export.instructions.part3')} "{t('button.import_file')}" {t('export.instructions.part4')} </Trans>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/4408.mdis excluded by!**/*.md
📒 Files selected for processing (18)
packages/desktop-client/src/components/accounts/Account.tsx(1 hunks)packages/desktop-client/src/components/budget/SidebarCategory.tsx(1 hunks)packages/desktop-client/src/components/budget/envelope/budgetsummary/TotalsList.tsx(2 hunks)packages/desktop-client/src/components/mobile/MobileNavTabs.tsx(3 hunks)packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx(3 hunks)packages/desktop-client/src/components/mobile/accounts/Accounts.tsx(1 hunks)packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx(2 hunks)packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx(4 hunks)packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx(2 hunks)packages/desktop-client/src/components/mobile/transactions/TransactionListItem.tsx(3 hunks)packages/desktop-client/src/components/modals/CategoryMenuModal.tsx(2 hunks)packages/desktop-client/src/components/modals/CreateLocalAccountModal.tsx(2 hunks)packages/desktop-client/src/components/modals/manager/ImportModal.tsx(1 hunks)packages/desktop-client/src/components/reports/ReportSidebar.tsx(2 hunks)packages/desktop-client/src/components/reports/reports/CustomReport.tsx(1 hunks)packages/desktop-client/src/components/reports/reports/Spending.tsx(5 hunks)packages/desktop-client/src/components/settings/Export.tsx(2 hunks)packages/desktop-client/src/components/transactions/TransactionsTable.jsx(3 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/desktop-client/src/components/accounts/Account.tsx
🧰 Additional context used
🧠 Learnings (4)
packages/desktop-client/src/components/mobile/accounts/Accounts.tsx (2)
Learnt from: joel-jeremy
PR: actualbudget/actual#3685
File: packages/desktop-client/src/components/accounts/Account.tsx:655-665
Timestamp: 2024-11-10T16:45:31.225Z
Learning: The Account component in 'packages/desktop-client/src/components/accounts/Account.tsx' is being rewritten in a separate PR.
Learnt from: qedi-r
PR: actualbudget/actual#3527
File: packages/desktop-client/src/components/accounts/Header.jsx:0-0
Timestamp: 2024-11-10T16:45:25.627Z
Learning: In the Actual Budget project, importing `t` directly from 'i18next' is acceptable and commonly used in the codebase.
packages/desktop-client/src/components/modals/CreateLocalAccountModal.tsx (2)
Learnt from: qedi-r
PR: actualbudget/actual#3527
File: packages/desktop-client/src/components/modals/CreateLocalAccountModal.tsx:47-47
Timestamp: 2024-11-10T16:45:25.627Z
Learning: Validating balance is outside the scope in `CreateLocalAccountModal.tsx`.
Learnt from: qedi-r
PR: actualbudget/actual#3527
File: packages/desktop-client/src/components/modals/CreateLocalAccountModal.tsx:32-33
Timestamp: 2024-11-10T16:45:31.225Z
Learning: In this codebase, account name uniqueness checks are case-sensitive, allowing account names that differ only by case.
packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (1)
Learnt from: matt-fidd
PR: actualbudget/actual#4181
File: packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx:252-254
Timestamp: 2025-01-18T20:08:55.203Z
Learning: Notification messages in BudgetTable.jsx will be translated in a separate PR to handle all translations together, as there are multiple messages to go through.
packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx (1)
Learnt from: MatissJanis
PR: actualbudget/actual#3570
File: packages/desktop-client/src/components/modals/ImportTransactionsModal/Transaction.tsx:83-90
Timestamp: 2024-11-10T16:45:25.627Z
Learning: In the `Transaction` component in `Transaction.tsx`, both `rawTransaction` and `transaction` should be included in the dependency arrays of `useMemo` hooks, even though `transaction` derives from `rawTransaction`.
🔇 Additional comments (25)
packages/desktop-client/src/components/mobile/transactions/TransactionListItem.tsx (1)
7-7: LGTM! Clean internationalization implementation.The changes correctly implement internationalization for the "(No payee)" string using react-i18next, aligning with the PR's translation objectives.
Also applies to: 54-54, 191-191
packages/desktop-client/src/components/transactions/TransactionsTable.jsx (3)
13-13: LGTM!The
Transcomponent is correctly imported alongside the existinguseTranslationimport fromreact-i18next.
1810-1810: LGTM!The "Cancel" button label is correctly wrapped with the
Transcomponent to enable internationalization.
1830-1830: LGTM!The "Add" button label is correctly wrapped with the
Transcomponent to enable internationalization.packages/desktop-client/src/components/reports/reports/Spending.tsx (5)
1-2: LGTM! Proper i18n setup.The file correctly imports and sets up the required internationalization hooks from
react-i18next.
156-157: LGTM! Notification message properly translated.The notification message is correctly wrapped with the translation function.
185-185: LGTM! Title translation properly implemented.The default title is correctly wrapped with the translation function in both places where it's used.
Also applies to: 191-191
243-244: LGTM! Mode labels properly translated.The 'Live' and 'Static' mode labels are correctly wrapped with the translation function.
282-283: LGTM! Comparison mode labels properly translated.The 'Budgeted' and 'Average spent' labels are correctly wrapped with the translation function.
packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (3)
10-10: LGTM!The import of translation utilities is correctly placed and both imported items are used in the code.
239-239: LGTM!The hardcoded text is correctly wrapped in the
Transcomponent for translation.
257-257: LGTM!The hardcoded text is correctly wrapped in the
Transcomponent for translation.packages/desktop-client/src/components/modals/manager/ImportModal.tsx (2)
25-61: LGTM! Good internationalization practices.The component demonstrates good internationalization practices:
- Proper usage of the
useTranslationhook- Correct application of the
tfunction for the modal title
69-97: LGTM! Comprehensive text content internationalization.All text content is properly wrapped with the
Transcomponent, ensuring complete internationalization coverage:
- Main instruction text
- YNAB4 description
- nYNAB description
- Actual description
packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx (2)
10-10: LGTM! Import added correctly.The
Transcomponent is imported alongsideuseTranslation, maintaining good import organization.
152-154: LGTM! Text internationalized correctly.The "No transactions" text is properly wrapped with the
Transcomponent, enabling translation support.packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (1)
491-497: LGTM! Well-structured translation implementation.The hardcoded message has been properly replaced with a translatable template using the
tfunction, with correct parameter substitution and dependency array update.Also applies to: 511-511
packages/desktop-client/src/components/reports/ReportSidebar.tsx (2)
1-67: LGTM! Well-structured imports and type definitions.The imports are properly organized, and the necessary translation hook is included.
98-98: LGTM! Translation hook is properly initialized.The
useTranslationhook is correctly initialized at the component level.packages/desktop-client/src/components/budget/envelope/budgetsummary/TotalsList.tsx (1)
124-137: LGTM! Internationalization is correctly implemented.The text strings are properly wrapped in
Transcomponents, and the dynamic variableprevMonthNameis correctly passed using object syntax.packages/desktop-client/src/components/budget/SidebarCategory.tsx (1)
127-132: LGTM! Menu items are correctly internationalized.The menu items are properly translated using the
t()function, including the conditional show/hide text.packages/desktop-client/src/components/modals/CategoryMenuModal.tsx (1)
119-121: LGTM! Menu items and notes are correctly internationalized.The menu items and notes fallback text are properly translated using the
t()function.Also applies to: 204-205, 211-212
packages/desktop-client/src/components/modals/CreateLocalAccountModal.tsx (1)
89-89: LGTM! Form labels and error messages are correctly internationalized.The form labels and error messages are properly translated using the
t()function. Note that account name uniqueness checks remain case-sensitive, allowing account names that differ only by case.Also applies to: 164-164, 182-182
packages/desktop-client/src/components/mobile/MobileNavTabs.tsx (1)
8-8: LGTM: Translation hook properly imported and initialized.The useTranslation hook is correctly imported and initialized.
Also applies to: 41-41
packages/desktop-client/src/components/settings/Export.tsx (1)
2-2: LGTM!The
Transcomponent import is correctly added alongsideuseTranslationto handle complex text blocks with HTML elements.
packages/desktop-client/src/components/mobile/accounts/Accounts.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
packages/desktop-client/src/components/budget/envelope/budgetsummary/TotalsList.tsx
Outdated
Show resolved
Hide resolved
packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx
Outdated
Show resolved
Hide resolved
packages/desktop-client/src/components/mobile/accounts/Accounts.tsx
Outdated
Show resolved
Hide resolved
packages/desktop-client/src/components/reports/ReportSidebar.tsx
Outdated
Show resolved
Hide resolved
packages/desktop-client/src/components/reports/ReportSidebar.tsx
Outdated
Show resolved
Hide resolved
packages/desktop-client/src/components/reports/reports/Spending.tsx
Outdated
Show resolved
Hide resolved
|
ty for the promptly review. I will change these stuff today ;) |
* 🐛 Fix Initializing the connection to the local database hang (actualbudget#4375) * fix initializing to the local db * release notes * Add percentage adjustments to schedule templates (actualbudget#4098) (actualbudget#4257) * add percentage adjustments to schedule templates * update release note * remove unecessary parentheses * Update packages/loot-core/src/server/budget/goalsSchedule.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * PR comments addressed * Linting fixes * Updated error handling, added tests * Linting fixes --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: youngcw <calebyoung94@gmail.com> * Custom mapping and import settings for bank sync providers (actualbudget#4253) * barebones UI * add saving and prefs * add last sync functionality * use mapping for synced transactions * note * jest -u * Update VRT * Coderabbit Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add new fields * rename migration, newer in master * lint * coderabbit * update snapshots * GoCardless handlers fallback and notes * expose new fields from SimpleFIN * update tests * update instructions on GoCardless handlers * lint * feedback * Update VRT --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: youngcw <calebyoung94@gmail.com> * Add fallback value for payeename: 'undefined' - CBC Bank (actualbudget#4384) * Add fallback value for payename: 'undefined' * docs: add release note * Add fallback value for payename: 'undefined' (for negative amounts) * [TypeScript] Convert test page models to TS (actualbudget#4218) * Dummy commit * Delete js snapshots * Move extended expect and test to fixtures * Fix wrong commit * Update VRT * Dummy commit to run GH actions * Convert test page models to TS * Release notes * Fix typecheck errors * New page models to TS * Fix typecheck error * Fix page name * Put awaits on getTableTotals --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * rename two migrations to realign with convention (actualbudget#4343) * Updating sync server package name to @actual-app/sync-server (actualbudget#4370) * updating sync server to have a consistent package name * release notes * Add today button on mobile budget page (actualbudget#4380) * feat: today button on mobile budget page Jumps to the current month * add release note * cleaner onCurrentMonth * Update VRT * use SvgCalendar from icons/v2 Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> * Update VRT --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> * Development mode for sync server (React Fast Refresh on port 5006) (actualbudget#4372) * devmode for sync server * removed pluggy from this version * md * code review * changed how open browser * missed this * linter * trigger actions * 🐛 Fix: Error rate limit at user directory page (actualbudget#4397) * Error rate limit * md * 🐛 Fix new proxy middleware dependency missing on prod build (actualbudget#4400) * fix new proxy middleware not installed on prod build * release notes * Remove deprecated imports for several components (actualbudget#4385) * don't unbudget goals * lint * Fixes actualbudget#4069 : Ignore CSV inOutMode during OFX imports (actualbudget#4382) * Ignore inOutMode during OFX imports * Add release notes --------- Co-authored-by: youngcw <calebyoung94@gmail.com> * fix tooltip translation (actualbudget#4402) * [TypeScript] Make `db.runQuery` generic to make it easy to type DB query results (actualbudget#4247) * Make runQuery generic to make it easy to type DB query results. * Release notes * typo * update mapping data for existing synced transactions and always show direction dropdown (actualbudget#4403) * update sync mapping data for existing transactions on sync * show payment direction dropdown regardless of sample data * note * ignore changes in raw_synced_data * Fix top-level types of `send` function (actualbudget#4145) * Add release notes * Fix types of `send` function * Fix `send` types in a number of places * PR feedback * Foundations for the budget automations UI (actualbudget#4308) * Foundations for the budget automations UI * Coderabbit * Fix react-hooks/exhaustive-deps error on useSelected.tsx (actualbudget#4258) * Fix react-hooks/exhaustive-deps error on useSelected.tsx * Release notes * Fix react-hooks/exhaustive-deps error on usePayees.ts (actualbudget#4260) * Fix react-hooks/exhaustive-deps error on usePayees.ts * Rename * Release notes * Fix react-hooks/exhaustive-deps error on useAccounts.ts (actualbudget#4262) * Fix react-hooks/exhaustive-deps error on useAccounts.ts * Release notes * Fix react-hooks/exhaustive-deps error on Titlebar.tsx (actualbudget#4273) * Fix react-hooks/exhaustive-deps error on Titlebar.tsx * Release notes * [WIP] BANKS_WITH_LIMITED_HISTORY constant update (actualbudget#4388) * Fix react-hooks/exhaustive-deps error on useProperFocus.tsx (actualbudget#4259) * Fix react-hooks/exhaustive-deps error on useProperFocus.tsx * Remove comment in eslint config * Release notes * Fix react-hooks/exhaustive-deps error on TransactionsTable.jsx (actualbudget#4268) * Fix react-hooks/exhaustive-deps error on TransactionsTable.jsx * Release notes * Fix lint * Fix react-hooks/exhaustive-deps error on table.tsx (actualbudget#4274) * Fix react-hooks/exhaustive-deps error on table.tsx * Release notes * Fix react-hooks/exhaustive-deps error on useCategories.ts (actualbudget#4261) * Fix react-hooks/exhaustive-deps error on useCategories.ts * Release notes * 👷 Typescript: Improving typing of asyncStorage (global-store.json) (actualbudget#4369) * typing globalprefs * adding release notes * unneeded partial * removing prop that crept in * 📚 Translation batch #1 (actualbudget#4408) * Translation batch * md * Update packages/desktop-client/src/components/settings/Export.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix code review from coderabbit * code review --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fix currencyToAmount incorrectly converting input (actualbudget#4383) * fix: ensure currencyToAmount works regardless of the configured number format * chore: linting * docs: add release note * test: ensure correct amount is entered for debit when adding split transactions * chore: rename variable thousandsSep to thousandsSeparator Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com> * chore: rename variable decimalSep to decimalSeparator Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com> * chore: rename decimalSep and thousandsSep variables to decimalSeparator and thousandsSeparator --------- Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com> * useDisplayPayee hook to unify payee names in mobile and desktop. (actualbudget#4213) * useDisplayPayee hook to unify payee logic in mobile and desktop * Release notes * Fix typecheck errors * Fix test * Update test * Revert (No payee) color * Fix tests * VRT * Fix category transactions * Fix lint and VRT * Update VRT * Translate --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Extract transaction related server handlers from `main.ts` to `server/transactions/app.ts` (actualbudget#4221) * Move transaction related handlers to server/transactions folder and use the new convention * Fix lint and typecheck * Release notes * Update handler names * Move get-earliest-transaction * Update release notes * Fix tests * Fix types * Fix lint * Update snapshot * Remove duplicate parse-file.ts * Fix lint * 🐛 Fix `On budget` / `Off budget` underline with translated languages (actualbudget#4417) * Fix `On budget` / `Off budget` underline * md * ajuste para o merge --------- Co-authored-by: Michael Clark <5285928+MikesGlitch@users.noreply.github.com> Co-authored-by: Matt Farrell <10377148+MattFaz@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: youngcw <calebyoung94@gmail.com> Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Martin Michotte <55855805+MMichotte@users.noreply.github.com> Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com> Co-authored-by: Adam Stück <adam@adast.dk> Co-authored-by: Alberto Cortina Eduarte <albertocortina96@gmail.com> Co-authored-by: Gabriel J. Michael <gabriel.j.michael@gmail.com> Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com> Co-authored-by: Michał Gołąb <23549913+michalgolab@users.noreply.github.com> Co-authored-by: Antoine Taillard <an.taillard@gmail.com>
More translations.
I'm dedicating some time to zero out all "old" strings that are not translated yet.
As far as I saw, I will do this in three batches.
This PR
The next one will focus on rules and schedules
The last will focus on dates (the one I started already)