Add fallback value for payeename: 'undefined' - CBC Bank (actualbudge…

…t#4384) * Add fallback value for payename: 'undefined' * docs: add release note * Add fallback value for payename: 'undefined' (for negative amounts)
lelemm · Feb 18, 2025 · 5b04cc3 · 5b04cc3
1 parent 9ae39bf
commit 5b04cc3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js b/packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js
@@ -16,14 +16,17 @@ export default {
 
     if (Number(transaction.transactionAmount.amount) > 0) {
       editedTrans.payeeName =
-        transaction.debtorName || transaction.remittanceInformationUnstructured;
+        transaction.debtorName ||
+        transaction.remittanceInformationUnstructured ||
+        'undefined';
     } else {
       editedTrans.payeeName =
         transaction.creditorName ||
         extractPayeeNameFromRemittanceInfo(
           transaction.remittanceInformationUnstructured,
           ['Paiement', 'Domiciliation', 'Transfert', 'Ordre permanent'],
-        );
+        ) ||
+        'undefined';
     }
 
     return Fallback.normalizeTransaction(transaction, booked, editedTrans);

diff --git a/upcoming-release-notes/4384.md b/upcoming-release-notes/4384.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MMichotte]
+---
+
+Provides a default fallback payeename value ('undefined') for the CBC bank in case the payeename is missing.