-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A "required" workflow is not started because of ignored files but the results are still required to submit the PR #1281
Comments
Hello @f-squirrel , probably, this workflow is marked as required check in your branch policies. |
@maxim-lobanov , thank you for the quick response. |
Yes, it is correct. Required check means that workflow MUST pass to merge the PR |
@maxim-lobanov , it looks like a bug. I'd expect a required workflow to return "true" if the PR's content is ignored by the workflow's rules. |
Reason: A PR cannot be submitted if a required check did not run. Even if the PR's content is ignored by the check. More information: actions/runner-images#1281
Hi @f-squirrel, we have an internal issue open tracking this problem. We've added your case to it. It's currently working as we had intended it. Required checks must have a success status for a merge to happen. This edge case is frustrating though. We've been discussing other ways to handle it. Such as looking if other commits have a success status. Your issue was added to the list, thanks for letting us know. |
I think this issue should not be closed. Even I like having the EDIT: |
I have a similar issue. PR workflow runs only for certain directories, but when enabling check in branch protection rules, other PRs cannot be merged (since waiting for the check status). |
Hi @alberttorosyan, |
@f-squirrel I was thinking of running the CI for every pull request, but checking the change list within the pipeline. It seems this is maximum we can achieve with current state of Github Actions... |
This issue has been closed. What is the solution? I am encountering the same issue. |
I'm interested in a solution for this too. |
The solution I found is to run a workflow on all file changes but ignore and skip steps with https://github.com/tj-actions/changed-files if specific files are not changed. This way workflow is marked as success and it finishes in a few seconds. |
Describe the bug
A "required" GitHub Action is not started because a PR's content is ignored by the action rules.
However, GitHub requires the results of the check.
As a result, the PR cannot be merged.
The link to PR.
The action is "clang-tidy".
Link to the workflow.
Area for Triage:
Bug
Virtual environments affected
Expected behavior
I'd expect the required check to be ignored by GitHub.
The text was updated successfully, but these errors were encountered: