Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "When only docs change, don't run build and lint workflows" #530

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Jul 13, 2022

Reverts #527.

Even though build and lint can be ignored for docs-only PRs, GitHub still expects them to run if they are required checks. I didn't notice this in my fork, because I didn't have the same protection rules after forking.

Also related: actions/runner-images#1281

@hariso hariso requested a review from a team as a code owner July 13, 2022 12:08
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The devil is once again in the details 😄

@hariso hariso merged commit c0a5a93 into main Jul 13, 2022
@hariso hariso deleted the revert-527-haris/no-builds-when-docs-only branch July 13, 2022 12:18
@hariso
Copy link
Contributor Author

hariso commented Jul 13, 2022

The devil is once again in the details smile

Definitely.:D It's also funny that, I actually had a fork with the protection rules, but I deleted it one or two days ago.: )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants