Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

PR unable to merge #174

Closed
tomaszwarda opened this issue Mar 15, 2023 · 1 comment · Fixed by #175
Closed

PR unable to merge #174

tomaszwarda opened this issue Mar 15, 2023 · 1 comment · Fixed by #175
Labels
bug Something isn't working

Comments

@tomaszwarda
Copy link
Contributor

Summary

PR is unable to merge if only .md files are edited, because unittest and analyze_workflow are ignoring those files. But merging changes require all checks to pass which is not happening, because 2 of 3 are not even started.

Proposed fix:

Delate from workflows those lines

    paths-ignore:
      - '**.md'

Logs and external information

image

Reproduction script

Make a PR with changes only to .md file.

On what platform(s) does it occur?

Not Applicable

Issue Severity

None

@tomaszwarda tomaszwarda added the bug Something isn't working label Mar 15, 2023
@sbasan
Copy link
Collaborator

sbasan commented Mar 15, 2023

There is other solution which will not produce unnecessary workload:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks

Also this discussion might be informative:
actions/runner-images#1281

But agree with complete path-filtering removal. This will keep CI simple. **/*.md doesn't look sophisticated and creating precise filter might be problematic. You may think that only **/*.py changes should be unit-tested but what about yaml templates - they might be used in unit-tests also.

@tomaszwarda tomaszwarda linked a pull request Mar 16, 2023 that will close this issue
5 tasks
@kagrski kagrski added this to the vManage-client 1.0.0 milestone Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants