Refactor aie.device to aie-rt lowering into library #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifield
force-pushed
the
aiertx
branch
2 times, most recently
from
8767951 to
30fc2a8
Compare
fifield
requested review from
stephenneuendorffer,
jgmelber and
erwei-xilinx
[wip] use transaction API rename add transaction bindings
stephenneuendorffer
approved these changes
Sep 10, 2024
Yu-Zhewen
added a commit
to nod-ai/iree-amd-aie
that referenced
this pull request
Jan 10, 2025
#1018) The following interface functions between the `xilinx::aie` dialect and `aie-rt` have been relocated and renamed `Target/AMDAIETargetCDODirect.cpp/addAieElfsToCDO` ->`Target/AMDAIERT.cpp/addAllAieElfs` `Target/AMDAIETargetCDODirect.cpp/addCoreEnableToCDO` -> `Target/AMDAIERT.cpp/addAllCoreEnable` `Target/AMDAIETargetCDODirect.cpp/addInitConfigToCDO` -> `Target/AMDAIERT.cpp/addInitConfig` The motivation is, these functions are not specific to the CDO and can be useful in other contexts, such as generating control packets. Brief documentation has also been added for these functions in the new header file. related: Xilinx/mlir-aie#1760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move aie-rt code from "cdo direct" translator into a library by cherry-picking and updating #1104.
This is mostly to make the translation easier use from other places:
will have merge conflicts with #1756