Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ctrl Pkt Reconfig E2E] New -aie-generate-ctrlpkt comilation mode in aiecc.py #1756

Merged
merged 17 commits into from
Sep 9, 2024
Merged

[Ctrl Pkt Reconfig E2E] New -aie-generate-ctrlpkt comilation mode in aiecc.py #1756

merged 17 commits into from
Sep 9, 2024

Conversation

erwei-xilinx
Copy link
Collaborator

@erwei-xilinx erwei-xilinx commented Sep 6, 2024 •
edited
Loading

  • Rewrite control packet reconfiguration end-to-end test to have control packet raw data compiler generated.
  • Directly translating to aiex.control_packet ops in aiecc.py, without going through txn2mlir.py prototype pass.
  • Rename aieTranslateToControlPackets to aieTranslateControlPacketsToUI32Vec to avoid confusion between converting to control packet to converting from control packets.

@erwei-xilinx erwei-xilinx changed the title [Ctrl Pkt Reconfig E2E] Rewrite control packet reconfiguration end-to-end test [Ctrl Pkt Reconfig E2E] New -aie-generate-ctrlpkt comilation mode in aiecc.py Sep 9, 2024
fifield
fifield reviewed Sep 9, 2024
View reviewed changes
include/aie/Targets/AIETargets.h Outdated Show resolved Hide resolved
include/aie/Targets/AIETargets.h Outdated Show resolved Hide resolved
lib/Targets/AIETargetCDODirect.cpp Outdated Show resolved Hide resolved
lib/Targets/AIETargets.cpp Outdated Show resolved Hide resolved
@fifield fifield mentioned this pull request Sep 9, 2024
Merged
@erwei-xilinx erwei-xilinx added this pull request to the merge queue Sep 9, 2024
Merged via the queue into Xilinx:main with commit 00bd68c Sep 9, 2024
67 checks passed
@erwei-xilinx erwei-xilinx deleted the rewrite_ctrl_pkt_test branch September 9, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifield fifield fifield approved these changes

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

@jgmelber jgmelber Awaiting requested review from jgmelber jgmelber is a code owner

@jackl-xilinx jackl-xilinx Awaiting requested review from jackl-xilinx jackl-xilinx is a code owner

@AndraBisca AndraBisca Awaiting requested review from AndraBisca AndraBisca is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erwei-xilinx @fifield