[pull] main from microsoft:main #447

pull · 2023-12-06T14:52:15Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

## Summary of the Pull Request Added open current directory action. ## References and Relevant Issues Need to set this: https://learn.microsoft.com/en-us/windows/terminal/tutorials/new-tab-same-directory ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed - Ensure shell has been configured - Run "Open current working directory" action in command palette - File explorer opens the correct directory ## PR Checklist - [x] Closes #12859 - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary)

Most of the logic is taken from the original PR (#15417) and adapted to work with the palette. ## References and Relevant Issues [#12382](#12382)

Closes #18055

This increases the console IO buffer size to retain at least 128KiB as this matches the default buffer size of `cat`. This avoids allocator churn due to constantly freeing and reallocating buffers. In the future this should ideally use a better suited, cheap allocator. Closes #18286

* Previously we would mark all gc=Cf (Control, format) codepoints as zero-width, but that ignores that the majority of them are also GCB=CN (Control = does not join), which meant we ended up with zero-width grapheme clusters. Those cannot exist under a terminal. So, this PR makes all gc=Cf, GCB=CN codepoints zero-width, but also treats them as Extender codepoints, which mirrors `wcswidth`. * This PR also updates the tables to Unicode 16.0. * Finally, there's a minor code cleanup of the generator. Closes #18267 ## Validation Steps Performed * Unit tests ✅ * Thai does not have random gaps anymore due to ZWSP ✅

Left, Top, Right and Bottom paddings can be set separetely in `Appearance`. I tried to make it as close as possible to one of the suggestions in #9127. I hope it doesn't look that bad. Closes #9127

If we colored a tab, then switched to another tab, there's a bug that the unselected tab loses its color. This was introduced in PR #18109. This PR fixes that by actually applying the selected color to the tab (whoops). Additionally, I removed setting the "TabViewItemHeaderCloseButtonBackground" resource because it looked weird (see comment in PR). Closes #18226

## Summary of the Pull Request Adds some pre-existing settings ($profile.foreground, $profile.background, $profile.selectionBackground, $profile.cursorColor) to the settings UI. This was accomplished by introducing a new control: NullableColorPicker. This control allows the user to pick a color from the color scheme, set the color to null, and select a color from an advanced color picker. Improves the UI for the Profile.Icon setting by adding an "Icon Type" combo box. This allows the user to pick from multiple options: - None: sets the icon to "none" which is interpreted as no icon - Built-in Icon: presents a combo box that enumerates the Segoe MDL 2 assets - Emoji: presents a text box with a hint to open the emoji picker - File: presents a text box to input the path of the image to use Additionally, the rendered icon is displayed in the setting container. If "none", "none" is presented to the user (localized). ## References and Relevant Issues #10000 ## Detailed Description of the Pull Request / Additional comments - NullableColorPicker control - includes a built-in NullColorButton to set the current value to null - includes a "More colors..." button to display an advanced color picker - uses data templates on data templates (data templates squared?) to convert the current color scheme into a grid of color chips - color chips display a checkmark (similar to Windows settings personalization). This automatically updates its color to stay compliant with color contrast. - color chips are added to a list so we can (un)check them when a new color is selected - SettingsContainer changes - Forked `ExpanderSettingContainerStyle` to allow for a custom preview template. This way, we can display the current value in the expander and we're not just limited to text. - changed type of `CurrentValue` property from `String` to `IInspectable` - added `CurrentValueTemplate` property to control how to display the current value - Miscellaneous: - Added a few converters (`BooleanToVisibility`, `ColorToString`, `ColorToBrush`) - Added `NameWithHexCode` to `ColorTableEntry` to expose a color as `Red #RRGGBB` (used for tooltips and a11y) - Added `ForegroundPreview` (and equivalent for other colors) to AppearanceViewModel to deduce the color that will be used ## Validation Steps Performed - [X] a11y pass (NVDA, keyboard) - [X] set the color to one of the color chips - [X] set the color to null - [X] set the color to a value from the integrated color picker - [X] control updates properly when a new color scheme is selected - [X] control updates properly when a color scheme has multiple colors of the same value ## Follow-ups - [A11y] Screen readers don't read expander's preview text - Add Tab Color to settings UI - Update CursorColor preview to display #FFFFFF as "invert" - Use Leonard's font picker UI, with the Segoe icon picker, so that you can filter the list

As before, a minor refactor: * I started off by removing the Monarch/Peasant with the goal of moving it into and deduplicating its functionality with `WindowEmperor`. * Since I needed a replacement for the Monarch (= ensures that there's a single instance), I wrote single-instance code with a NT mutex and by yeeting data across processes with `WM_COPYDATA`. * This resulted in severe threading issues, because it now started up way faster. The more I tried to solve them the deeper I had to dig, because you can't just put a mutex around `CascadiaSettings`. I then tried to seeif WinUI can run multiple windows on a single thread and, as it turns out, it can. So, I removed the multi- from the window threading. * At this point I had dig about 1 mile deep and brought no ladder. So, to finish it up, I had to clean up the entire eventing system around `WindowEmperor`, cleaned up all the coroutines, and cleaned up all the callbacks. Closes #16183 Closes #16221 Closes #16487 Closes #16532 Closes #16733 Closes #16755 Closes #17015 Closes #17360 Closes #17420 Closes #17457 Closes #17799 Closes #17976 Closes #18057 Closes #18084 Closes #18169 Closes #18176 Closes #18191 ## Validation Steps Performed * It does not crash ✅ * New/close tab ✅ * New/close window ✅ * Move tabs between windows ✅ * Split tab into new window ✅ * Persist windows on exit / restore startup ✅

## Summary of the Pull Request Adds the Profile.BellSound setting to the Settings UI under the Profile > Advanced page. - View changes: - The setting is exposed via an expander placed near the Profile.BellStyle setting. - Added a button to be able to preview the added sound - Added a browse button that opens a file picker - Added a delete button to be able to delete each sound entry - View model changes: - `CurrentBellSounds` keeps track of the bell sounds added and exposed via the UI. - `BellSoundViewModel` wraps each sound. This allows us to listen (and propagate) changes to the registered sounds. - `BellSoundPreview` provides a written preview of the current bell sound to display in the expander #10000

CodeQL is raising errors when building Visual Studio since we have a dependency on Windows Terminal for our integrated terminal. The issue raised is not applicable to this case and therefore requires a suppression comment to ignore the raised error.

Forgetti di spaghetti in #18215. Closes #18324 ## Validation Steps Performed * Launch through the start menu * Explicitly minimize * Then... * Launch through the start menu again ✅ * Launch via wtd.exe in Win+R ✅ * Launch via wtd.exe in another Terminal ✅ * Launch via handoff ✅

Closes #18037

github-actions · 2024-12-13T20:42:37Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (179)

aarch
abi
activatable
admins
amd
apc
applets
argb
ASDF
ative
AVX
azzle
backpressure
BGR
bitmask
Bopomofo
BOTTOMLEFT
BOTTOMRIGHT
bstr
calt
cbuffer
cci
CFlags
changelist
Checkin
chk
cielab
clig
cls
cmt
cmyk
cnt
CNTRL
codepage
codepoints
colorspaces
COMDAT
configurability
cred
Crt
CUI
dbg
distro
django
DLOAD
ect
ectread
efg
efgh
egistry
elease
elems
emacs
emplates
enderer
endregion
eplace
erm
erminal
erminalcore
erminalinput
esource
estlist
estmd
estpasses
ests
esult
esultmacros
flyout
FONTFAMILY
FONTSIZE
FONTWEIGHT
FSCTL
GAUSSIAN
gcc
getch
GETFONTSIZE
GETPOS
GNUC
groupbox
GTR
HALFWIDTH
hashtable
HORZ
hread
hrottled
hsl
icket
Iconified
idx
ihilist
inheritdoc
inlines
ioctl
keydown
keyup
LFs
listdir
lnk
lss
MMIX
MOUSEMOVE
msys
nameof
natvis
Nop
NOUPDATE
nullability
numpad
oklab
ools
OOM
osign
otepad
ouicompat
passthrough
pcs
pgdn
pgup
pkey
prefs
prepopulated
ptrs
qos
rasterizer
RCDATA
rcl
rects
reparent
RGBCOLOR
roundtrips
RTTI
safearray
sapi
scancode
scrollbars
sdl
SETCOLOR
SETFONT
Shl
SND
srgb
Statusline
stl
strrev
subfolders
subkey
swappable
taskbar
testenv
texel
titlebar
TOPLEFT
TOPRIGHT
tprivapi
tsf
typelib
typeparam
UDM
uget
UIs
ules
umul
umulh
Uninitialize
untimes
upkg
vcpkg
vec
vectorized
versioned
vtable
walkthrough
WCAG
WINDOWTITLE
workaround
YDPI
YOffset
ype

Previously acknowledged words that are now absent

APCs Argb bitmasks changelists Cmts codenav codepages DISPATCHNOTIFY distros EFG EFGh flyouts gitlab IInput Ioctl keydowns keyups nerror rectread reparented resultmacros scancodes subkeys testenvs titlebars tvtseq :arrow_right:

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the git@github.com:microsoft/terminal.git repository
on the main branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/Xen0byte/terminal/actions/runs/12322710887/attempts/1'

Errors (1)

See the 📂 files view or the 📜action log for details.

❌ Errors	Count
❌ check-file-path	1

See ❌ Event descriptions for more information.

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

If the listed items are:

... misspelled, then please correct them instead of using the command.
... names, please add them to .github/actions/spelling/allow/names.txt.
... APIs, you can add them to a file in .github/actions/spelling/allow/.
... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

pull bot added the ⤵️ pull label Dec 6, 2023