Added CodeQL supression comment #18315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
approved these changes
Dec 12, 2024
carlos-zamora
approved these changes
Dec 12, 2024
DHowett
pushed a commit
that referenced
this pull request
Dec 13, 2024
CodeQL is raising errors when building Visual Studio since we have a dependency on Windows Terminal for our integrated terminal. The issue raised is not applicable to this case and therefore requires a suppression comment to ignore the raised error. (cherry picked from commit 19460f9) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgVqzx8 Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
Dec 13, 2024
CodeQL is raising errors when building Visual Studio since we have a dependency on Windows Terminal for our integrated terminal. The issue raised is not applicable to this case and therefore requires a suppression comment to ignore the raised error. (cherry picked from commit 19460f9) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgVqzyA Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
CodeQL is raising errors when building Visual Studio since we have a dependency on Windows Terminal for our integrated terminal. The issue raised is not applicable to this case and therefore requires a suppression comment to ignore the raised error.
References and Relevant Issues
CodeQL error: https://liquid.microsoft.com/codeql/issues/794ce24e-f563-420c-b611-351ab9a2b700?copilot_promptid=E91B0CE9-0C1B-4AC2-8A46-33F49B67E058
Detailed Description of the Pull Request / Additional comments
Adds a CodeQL suppression comment to specifically ignore the error raised by CodeQL.
Validation Steps Performed
PR Checklist