Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Guava dependency #131

Closed
occupant23 opened this issue Aug 20, 2020 · 5 comments
Closed

Remove Guava dependency #131

occupant23 opened this issue Aug 20, 2020 · 5 comments
Assignees
@occupant23 @oomelianchuk
Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there improvement Medium Priority
Milestone
v4.0.0

Comments

@occupant23
Copy link
Contributor

The guava dependency: com.google.guava is only used in one place and this code can easily replaced by using streams.
@occupant23 occupant23 added this to the v3.7.0 milestone Aug 20, 2020
@occupant23 occupant23 self-assigned this Aug 20, 2020
occupant23 pushed a commit that referenced this issue Aug 20, 2020
#131: removed guava dependency
e872769
@occupant23 occupant23 added the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Aug 20, 2020
@occupant23
Copy link
Contributor Author

@oomelianchuk Please recheck.

@oomelianchuk
Copy link
Contributor

Hurra! We have one dependency less on the project and used Java 8 instead. That's wonderful!

@occupant23 occupant23 added the codeDone The issue is rechecked for development branch label Aug 21, 2020
@h-arlt
Copy link
Contributor

h-arlt commented Aug 24, 2020

Unfortunately, Guava is not completely gone. It is still a transitive dependency of browserup-proxy-core.

@occupant23
Copy link
Contributor Author

That's okay. I just wanted to remove the explicit dependency due to one line of code.

@h-arlt
Copy link
Contributor

h-arlt commented Aug 26, 2020

Totally right.

occupant23 referenced this issue Aug 28, 2020
Merge branch 'develop' into #121-print-stack-trace
45c0dc6 
# Conflicts:
#	src/test/java/com/xceptance/neodymium/tests/NeodymiumWebDriverTest.java
occupant23 pushed a commit that referenced this issue Aug 31, 2020
#131: simplified implementation
45fbe26
@occupant23 occupant23 mentioned this issue Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@occupant23 occupant23

@oomelianchuk oomelianchuk

Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there improvement Medium Priority
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
3 participants
@h-arlt @occupant23 @oomelianchuk