New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#121 print stack trace #137

Merged

occupant23 merged 22 commits into develop from #121-print-stack-trace

Sep 1, 2020

Contributor

occupant23 commented Aug 28, 2020

No description provided.

oomelianchuk and others added 7 commits

July 22, 2020 16:30


          #121 print stack trace

93397a6


          add documentation and test for checkPass and checkFail methods

eeed6fb


          remove expectedFailCount parameter from checkPass and replace with 0

49c5885


          split checkFail into 3 methods and test them

747a374


          Merge branch 'develop' into #121-print-stack-trace

45c0dc6

# Conflicts:
#	src/test/java/com/xceptance/neodymium/tests/NeodymiumWebDriverTest.java


          removed warnings

318b84d


          #121: change naming

f94d333

occupant23 requested a review from h-arlt

August 28, 2020 11:59

occupant23 self-assigned this

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved


          used stream to parse stack trace to String

e0ed3b7

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTestSelfTest.java Outdated Show resolved Hide resolved

oomelianchuk force-pushed the #121-print-stack-trace branch from 37d6b31 to e0ed3b7 Compare

August 28, 2020 13:30

oomelianchuk added 6 commits

August 28, 2020 15:32


          all variables in NeodymiumTestSelfTest made to final

fffaf86


          build a map using java 9

2e5f720


          RuntimeException replaced with Assert.fail

61e36ac


          check for expectedFailureMessages is not null extracted into if clause


          all variables in NeodymiumTest made to final

3178ba4


          javadoc improved

cec8639

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

h-arlt reviewed

View reviewed changes

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved

Marcel Pfotenhauer and others added 6 commits

August 31, 2020 15:28


          #121: simplified code by usin Map.of()

2ac1cd1


          #121: added a newline

7d95390


          Merge branch 'develop' into #121-print-stack-trace

ea99f08


          Merge branch 'develop' into #121-print-stack-trace

761865a

# Conflicts:
#	src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java


          Merge branch '#121-print-stack-trace' of https://github.com/Xceptance…

1b1ba60

…/neodymium-library into #121-print-stack-trace


          #121: added java doc

a4e192d

occupant23 requested a review from h-arlt

August 31, 2020 19:23

Contributor Author

occupant23 commented Aug 31, 2020

@h-arlt : Everything should now be fixed. Please review again.


          #121: added java doc

98dcbf8

h-arlt reviewed

View reviewed changes

Contributor

h-arlt left a comment

Looks good to me. Only few small issues. See my comments.

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Show resolved Hide resolved

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Show resolved Hide resolved

src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java Outdated Show resolved Hide resolved


          #121: improved java doc

862d3ec

occupant23 requested a review from h-arlt

September 1, 2020 08:58

h-arlt approved these changes

View reviewed changes

Contributor

h-arlt left a comment

Ready for merge ;-)

occupant23 merged commit 3ddd0eb into develop

occupant23 deleted the #121-print-stack-trace branch

September 1, 2020 09:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet