Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the NeodymiumTest class #121

Closed
3 tasks
occupant23 opened this issue Apr 3, 2020 · 1 comment
Closed
3 tasks

Improve the NeodymiumTest class #121

occupant23 opened this issue Apr 3, 2020 · 1 comment
Assignees
@oomelianchuk
Labels
codeDone The issue is rechecked for development branch docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop feature improvement Low Priority
Milestone
v4.0.0

Comments

@occupant23
Copy link
Contributor

The NeodymiumTest is working fine so far bit it could be extended.

  • Research if it's possible to retrieve and provide the stack traces of failed executions for debugging reasons
  • The test function for failure "checkFail" does not work as expected every time especially with multiple exception you can't use everything the signature promises
  • Add JavaDoc to the methods to help everybody understanding what can be done.
@occupant23 occupant23 added feature improvement docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop Low Priority labels Apr 3, 2020
@occupant23 occupant23 added this to the v3.7.0 milestone Apr 3, 2020
oomelianchuk added a commit that referenced this issue Jul 22, 2020
@oomelianchuk
#121 print stack trace
93397a6
@occupant23
Copy link
Contributor Author

The stacktrace should be added to the raised exception so that it is available in reports and or within the IDE. Only printing it is only polluting the console.

occupant23 pushed a commit that referenced this issue Aug 27, 2020
Merge branch 'develop' into #121-print-stack-trace
45c0dc6 
# Conflicts:
#	src/test/java/com/xceptance/neodymium/tests/NeodymiumWebDriverTest.java
occupant23 pushed a commit that referenced this issue Aug 28, 2020
#121: change naming
f94d333
occupant23 pushed a commit that referenced this issue Aug 31, 2020
#121: simplified code by usin Map.of()
2ac1cd1
occupant23 pushed a commit that referenced this issue Aug 31, 2020
#121: added a newline
7d95390
h-arlt added a commit that referenced this issue Aug 31, 2020
@h-arlt
Merge branch 'develop' into #121-print-stack-trace
ea99f08
occupant23 pushed a commit that referenced this issue Aug 31, 2020
Merge branch 'develop' into #121-print-stack-trace
761865a 
# Conflicts:
#	src/test/java/com/xceptance/neodymium/tests/NeodymiumTest.java
occupant23 pushed a commit that referenced this issue Aug 31, 2020
Merge branch '#121-print-stack-trace' of https://github.com/Xceptance…
1b1ba60 
…/neodymium-library into #121-print-stack-trace
occupant23 pushed a commit that referenced this issue Aug 31, 2020
#121: added java doc
a4e192d
occupant23 pushed a commit that referenced this issue Sep 1, 2020
#121: added java doc
98dcbf8
occupant23 pushed a commit that referenced this issue Sep 1, 2020
#121: improved java doc
862d3ec
occupant23 added a commit that referenced this issue Sep 1, 2020
@occupant23
Merge pull request #137 from Xceptance/#121-print-stack-trace
3ddd0eb 
#121 print stack trace
@occupant23 occupant23 added the codeDone The issue is rechecked for development branch label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oomelianchuk oomelianchuk

Labels
codeDone The issue is rechecked for development branch docsReadyForMerge Documentation was created for this issue in a separate branch which is ready to merge to develop feature improvement Low Priority
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@occupant23 @oomelianchuk