Staging API does not automatically deploy after merge to main #971
Labels
🤖 aspect: dx
Concerns developers' experience with the codebase
🛠 goal: fix
Bug fix
🟧 priority: high
Stalls work on the project or its dependents
🧱 stack: mgmt
Related to repo management and automations
Comments
sarayourfriend
added
🟧 priority: high
4 tasks
dhruvkb
pushed a commit
that referenced
this issue
Apr 14, 2023
…a new AudioCategory class, and removing 2 troublesome test directories (#971) * Delete tests/dags/common/test_resources/logs/test_dag/test_task/2021-08-10T00:00:00+0000 directory Attempting to remove this directory of test log files to see if it fixes my git cloning issue: error: invalid path 'tests/dags/common/test_resources/logs/test_dag/test_task/2021-08-10T00:00:00+0000/1.log' fatal: unable to checkout working tree warning: Clone succeeded, but checkout failed. You can inspect what was checked out with 'git status' and retry with 'git restore --source=HEAD :/' * Delete tests/dags/common/test_resources/logs/test_dag/test_task/2021-08-20T00:00:00+0000 directory Removing directory to see if it fixes my git cloning issue: error: invalid path 'tests/dags/common/test_resources/logs/test_dag/test_task/2021-08-10T00:00:00+0000/1.log' fatal: unable to checkout working tree warning: Clone succeeded, but checkout failed. You can inspect what was checked out with 'git status' and retry with 'git restore --source=HEAD :/' * Added AudioCategory class, and took out Enum derivative from ImageCategory class. Closes issue #823. * Corrected the references to our ImageCategory class given that we removed the Enum derivative. It is a direct class reference now. * Added back the troublesome log files per reviewer's request. Related to issue #823 and pull request #971 * Update openverse_catalog/dags/common/loader/provider_details.py Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu> * Update openverse_catalog/dags/common/loader/provider_details.py Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu> --------- Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The staging API deployment workflow is not being triggered by the CI/CD workflow when merges to main pass CI.
Reproduction
Merge to main with API changes and note that staging doesn't automatically deploy. You can see this is the case in two places.
In the deployment workflow itself you can see that Zack and I have manually run the workflow and that those are the only instances of it running.
Likewise, you can see the CI/CD workflow on
mainthat include API changes, like the following ones, all skip the API deployment:https://github.com/WordPress/openverse/actions/runs/4470063731
https://github.com/WordPress/openverse/actions/runs/4449387262
https://github.com/WordPress/openverse/actions/runs/4443742095
Additional context
Marked as high because it doesn't match developer expectations which causes delays when testing critical PRs (for example, the ones attempting to address the production incident over the last few days).
Pinging @AetherUnbound and @dhruvkb as the most expert maintainers in this area for help/ideas debugging if y'all have time.
The text was updated successfully, but these errors were encountered: