Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the analytics notification #823

Closed
dhruvkb opened this issue Mar 2, 2023 · 1 comment · Fixed by #2132
Closed

Create the analytics notification #823

dhruvkb opened this issue Mar 2, 2023 · 1 comment · Fixed by #2132
Labels
💻 aspect: code Concerns the software code in the repository design: needed Needs a designer's touch before implementation can begin 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Milestone
Analytics

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Mar 2, 2023

Description

Although we plan our analytics system to be privacy-oriented and GDPR compliant, in the interest of transparency we would like to inform users that the site has analytics and show them where they can opt-out.

This could potentially be a banner, which is a UI element we have used in the past for the CC Search to Openverse migration and to notify of incomplete translations. Showing multiple banners on one page might not look very pretty but that's something that @panchovm can help out with.

Additional context

RFC: https://github.com/WordPress/openverse/blob/3fa9f03937d2af356535f158f7f80b20a6bd79d2/rfcs/analytics/20221006-implementation_plan_frontend.md
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Mar 2, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Mar 2, 2023
@dhruvkb dhruvkb added this to the Analytics milestone Mar 2, 2023
@dhruvkb dhruvkb added the design: needed Needs a designer's touch before implementation can begin label Mar 3, 2023
@dhruvkb dhruvkb added 🟧 priority: high Stalls work on the project or its dependents and removed 🟨 priority: medium Not blocking but should be addressed soon labels Apr 12, 2023
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
@flamesjames @AetherUnbound
Stripping the ImageCategory class of its "Enum" derivative, creating …
d36aa8d 
…a new AudioCategory class, and removing 2 troublesome test directories (#971)

* Delete tests/dags/common/test_resources/logs/test_dag/test_task/2021-08-10T00:00:00+0000 directory

Attempting to remove this directory of test log files to see if it fixes my git cloning issue:

error: invalid path 'tests/dags/common/test_resources/logs/test_dag/test_task/2021-08-10T00:00:00+0000/1.log'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

* Delete tests/dags/common/test_resources/logs/test_dag/test_task/2021-08-20T00:00:00+0000 directory

Removing directory to see if it fixes my git cloning issue: 

error: invalid path 'tests/dags/common/test_resources/logs/test_dag/test_task/2021-08-10T00:00:00+0000/1.log'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

* Added AudioCategory class, and took out Enum derivative from ImageCategory class. Closes issue #823.

* Corrected the references to our ImageCategory class given that we removed the Enum derivative. It is a direct class reference now.

* Added back the troublesome log files per reviewer's request. Related to issue #823 and pull request #971

* Update openverse_catalog/dags/common/loader/provider_details.py

Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>

* Update openverse_catalog/dags/common/loader/provider_details.py

Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>

---------

Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
@dhruvkb
Copy link
Member Author

dhruvkb commented May 18, 2023

Related to #2015.

@dhruvkb dhruvkb mentioned this issue May 18, 2023
Merged
8 tasks
@dhruvkb dhruvkb linked a pull request May 19, 2023 that will close this issue
Update banner to match new designs and add analytics notification #2132
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository design: needed Needs a designer's touch before implementation can begin 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
Analytics
Development

Successfully merging a pull request may close this issue.

Update banner to match new designs and add analytics notification WordPress/openverse
1 participant
@dhruvkb