Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix needs check on api staging deployment #975

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Fix needs check on api staging deployment #975

merged 1 commit into from
Mar 21, 2023

Conversation

sarayourfriend
Copy link
Collaborator

Fixes

Fixes #971 by @sarayourfriend

cc @zackkrida who was asking about this earlier this week.

Description

I think this is the issue: that it was checking for needs.test-ing rather than test-api. test-ing isn't in the needs array. It's a shame that action lint doesn't catch this error... but that makes me wonder whether I'm missing something (is needs-ing still available, somehow?).

Anyway, I'm not sure how to test this other than to merge the PR and see if staging API deploys 😁

Testing Instructions

Verify the fix makes sense.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • [N/A] I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend requested a review from a team as a code owner March 21, 2023 03:19
@github-actions github-actions bot added 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: frontend Related to the Nuxt frontend labels Mar 21, 2023
@github-actions
Copy link

Size Change: -236 B (0%)

Total Size: 882 kB

Filename Size Change
./frontend/.nuxt/dist/client/235.js 1.85 kB +1.58 kB (+578%) 🆘
./frontend/.nuxt/dist/client/235.modern.js 0 B -278 B (removed) 🏆
./frontend/.nuxt/dist/client/236.js 0 B -1.85 kB (removed) 🏆
./frontend/.nuxt/dist/client/app.js 143 kB -114 B (0%)
./frontend/.nuxt/dist/client/app.modern.js 117 kB -122 B (0%)
./frontend/.nuxt/dist/client/234.js 273 B +273 B (new file) 🆕
./frontend/.nuxt/dist/client/234.modern.js 277 B +277 B (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./frontend/.nuxt/dist/client/commons/app.js 87.8 kB 0 B
./frontend/.nuxt/dist/client/commons/app.modern.js 78.3 kB 0 B
./frontend/.nuxt/dist/client/components/loading-icon.js 747 B 0 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 753 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 515 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 518 B 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 8.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 5.49 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-cell.js 392 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js 397 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-details.js 2.55 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-details.modern.js 1.79 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 1.02 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.22 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.18 kB 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 543 B 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 547 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.js 693 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 697 B 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.24 kB 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.24 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.js 1.12 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-page.js 526 B 0 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 530 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 785 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 789 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 6.11 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.59 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 1.24 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 4.25 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.js 4 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js 9.96 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js 9.94 kB 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 754 B 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 758 B 0 B
./frontend/.nuxt/dist/client/components/v-error-image.js 1.7 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 1.69 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-section.js 372 B 0 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 376 B 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 1.93 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 1.92 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.js 905 B 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 906 B 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.52 kB 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.52 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.62 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.63 kB 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 5.18 kB 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 5.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.76 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.73 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-carousel.js 4.73 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js 4.71 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.57 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.56 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-details.js 2.16 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.99 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 2.52 kB 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 526 B 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 529 B 0 B
./frontend/.nuxt/dist/client/components/v-load-more.js 3.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 695 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.js 829 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 837 B 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 1.63 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 1.63 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.js 434 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 439 B 0 B
./frontend/.nuxt/dist/client/components/v-modal.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 996 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.js 757 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 756 B 0 B
./frontend/.nuxt/dist/client/components/v-radio.js 1.51 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.47 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.js 1.26 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 1.26 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-images.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 3.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 977 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 981 B 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.71 kB 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.72 kB 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.js 824 B 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 830 B 0 B
./frontend/.nuxt/dist/client/components/v-search-grid.js 5.75 kB 0 B
./frontend/.nuxt/dist/client/components/v-search-grid.modern.js 5.68 kB 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.js 600 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 604 B 0 B
./frontend/.nuxt/dist/client/components/v-search-type-radio.js 806 B 0 B
./frontend/.nuxt/dist/client/components/v-search-type-radio.modern.js 781 B 0 B
./frontend/.nuxt/dist/client/components/v-server-timeout.js 299 B -1 B (0%)
./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 3.39 kB 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 913 B 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.19 kB 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.19 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.js 16.2 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 16.2 kB 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B 0 B
./frontend/.nuxt/dist/client/pages/about.js 1.4 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/about.modern.js 1.4 kB 0 B
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 8.01 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 4.85 kB 0 B
./frontend/.nuxt/dist/client/pages/external-sources.js 1.56 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/external-sources.modern.js 1.56 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.js 1.34 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.34 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/index.js 9.32 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 5.18 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/report.js 3.66 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.27 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/index.js 7.28 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/index.modern.js 7.21 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/preferences.js 1.32 kB 0 B
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.32 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.02 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/search-help.js 1.6 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.58 kB 0 B
./frontend/.nuxt/dist/client/pages/search.js 4.55 kB 0 B
./frontend/.nuxt/dist/client/pages/search.modern.js 2.04 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/search/audio.js 6.02 kB +2 B (0%)
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 3.55 kB 0 B
./frontend/.nuxt/dist/client/pages/search/image.js 508 B +1 B (0%)
./frontend/.nuxt/dist/client/pages/search/image.modern.js 2.71 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/search/index.js 443 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 448 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 244 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 247 B +1 B (0%)
./frontend/.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B 0 B
./frontend/.nuxt/dist/client/pages/sources.js 1.57 kB 0 B
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.57 kB 0 B
./frontend/.nuxt/dist/client/runtime.js 2.72 kB -1 B (0%)
./frontend/.nuxt/dist/client/runtime.modern.js 2.73 kB -1 B (0%)
./frontend/.nuxt/dist/client/vendors/app.js 64.2 kB -1 B (0%)
./frontend/.nuxt/dist/client/vendors/app.modern.js 63.3 kB 0 B

compressed-size-action

@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations and removed 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: frontend Related to the Nuxt frontend labels Mar 21, 2023
@sarayourfriend
Copy link
Collaborator Author

Jeez, the label check actions got totally fried on this one. It added three stack labels (API, ingestion server, and frontend) but didn't copy any of the other labels from the issue (aspect, priority, etc).

@github-actions
Copy link

github-actions bot commented Mar 21, 2023 •
edited
Loading

Full-stack documentation: Ready

https://WordPress.github.io/openverse/_preview/975

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

zackkrida
zackkrida approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think this is correct, but @dhruvkb would likely be best to confirm, despite his likely exhaustion of looking at CI/CD issues!

dhruvkb
dhruvkb approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch. The API deploy definitely depends on the API test.

@zackkrida zackkrida merged commit ce0fe2b into main Mar 21, 2023
@zackkrida zackkrida deleted the fix/staging-api-auto-deploy branch March 21, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackkrida zackkrida zackkrida approved these changes

@dhruvkb dhruvkb dhruvkb approved these changes

@obulat obulat Awaiting requested review from obulat obulat is a code owner automatically assigned from WordPress/openverse-maintainers

Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: mgmt Related to repo management and automations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Staging API does not automatically deploy after merge to main
3 participants
@sarayourfriend @zackkrida @dhruvkb