This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Make audio/image pages without ids show a 404 #768
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #496 by @obulat
Description
Adds an
index.vue
to theimage
andaudio
page directories so that we can render a 404 page when a single result route without an id is hit.I'm not sure if this is really the right way to do this... I couldn't find any solid evidence about this and redirecting to
/404
seems incorrect for some reason. If we prefer that though, we can do that instead of this. I do like that this is a little more on the "declarative" side of things rather than programatically testing the route.Testing Instructions
Checkout the branch and run
pnpm dev
. Visit/image/
without an id and/audio/
without an id and verify that they show the 404 page.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin