Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add inline-start border to filters on desktop #748

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Add inline-start border to filters on desktop #748

merged 2 commits into from
Jan 28, 2022

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jan 28, 2022

Fixes

Fixes #729 by @panchovm

Description

This PR adds a border to the left (in LTR, and right in RTL) side of the filter sidebar on desktop screen. To be honest, with my settings for scrollbar visibility, it is not easy to see:

Screen Shot 2022-01-28 at 6 37 07 AM

Testing Instructions

Run the app, and open the filters sidebar. You should see a border between the sidebar and the main content.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software labels Jan 28, 2022
@obulat obulat requested a review from a team as a code owner January 28, 2022 03:48
@obulat
Copy link
Contributor Author

obulat commented Jan 28, 2022

Screenshot after changing the scrollbar properties and setting the locale direction to RTL
Screen Shot 2022-01-28 at 6 50 12 AM

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation. Minor code style nitpick. Approving to unblock.

src/components/VFilters/VSearchGridFilter.vue Outdated Show resolved Hide resolved
@fcoveram
Copy link

It looks great ✨

To be honest, with my settings for scrollbar visibility, it is not easy to see

Same to me when scrolling, but the section division is visible once the scroll bar disappears. Many people have different settings where the scrolling effect looks unalike.

Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
@obulat
Copy link
Contributor Author

obulat commented Jan 28, 2022

Great implementation. Minor code style nitpick. Approving to unblock.

Thank you, @dhruvkb , I wasn't aware of the @screen option!

@obulat obulat requested a review from fcoveram January 28, 2022 14:41
Copy link

@fcoveram fcoveram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ✨

@obulat obulat merged commit 168ed15 into main Jan 28, 2022
@obulat obulat deleted the filters_border branch January 28, 2022 15:02
rbadillap added a commit that referenced this pull request Feb 2, 2022
* main: (73 commits)
  Make audio/image pages without ids show a 404 (#768)
  Fix logo button paddings and simplify implementation (#767)
  Fix global audio rtl close placement (#780)
  Check for `null` localStorage explicitly (#763)
  Truncate global audio text to two lines (#773)
  New image details page (#682)
  Switch to path-based i18n routing (#701)
  Enable source maps in production (#755)
  Remove Jamendo and Wikimedia Commons from audio meta sources (#747)
  Use jed1x json format to correctly handle pluralization (#753)
  Fix logo color on error page layout (#752)
  Add homepage content switcher for mobile screens (#716)
  Add inline-start border to filters on desktop (#748)
  Fix header items not fitting in (#718)
  Expose `close` to popover content via slot props (#736)
  Truncate row layout audio titles (#735)
  Stop blocking on analytics requests (#715)
  Style links globally (#727)
  Refactor the usage of i18n result count computation (#707)
  Use `VPopover` for the content report form (#719)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Border style in Filters sidebar
3 participants