This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #754 by @sarayourfriend
Description
Enables source maps in production so that Sentry can use them for better stack traces in issues.
Does not effect the dev experience at all as they were already enabled in development, this PR just removes the "isDev" check that was guarding source map generation.
This will slightly slow down the production build but IMO that's the least concern (I'm more concerned that we're using production quality source maps in development and we could get a dev performance win if we switched to a different source map generation technique in dev, but that's another story altogether and our dev build is still pretty fast anyway).
Testing Instructions
Run
pnpm build && pnpm start
and verify that you can access the source maps in your browser.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin