This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Create a box layout for the audio component #230
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dhruvkb
added
🌟 goal: addition
Addition of new feature
💻 aspect: code
Concerns the software code in the repository
labels
Sep 16, 2021
@dhruvkb is the global audio player work happening here? that makes sense if so, just curious |
@zackkrida no that's happening in the |
Also, this PR is very much a draft, the box design has changed a lot from this implementation and the states aren't documented in detail in Figma. So this will be WIP for the foreseeable future. |
…into box_layout
I think I'll just close this and combine the work into #504. |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
💻 aspect: code
Concerns the software code in the repository
🌟 goal: addition
Addition of new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #228 by @zackkrida
Description
This PR uses the AudioTrack composability introduced in #207 to provide a Box layout for the audio.
Technical details
The box layout is currently in the design phase, and there are certain feedback points to address, but this PR serves as a PoC for the composability of the track.
Screenshots
Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin