Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Create a box layout for the audio component #230

Closed
wants to merge 17 commits into from
Closed

Create a box layout for the audio component #230

wants to merge 17 commits into from

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 16, 2021

Fixes

Fixes #228 by @zackkrida

Description

This PR uses the AudioTrack composability introduced in #207 to provide a Box layout for the audio.

Technical details

The box layout is currently in the design phase, and there are certain feedback points to address, but this PR serves as a PoC for the composability of the track.

Screenshots

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida linked an issue Sep 16, 2021 that may be closed by this pull request
@dhruvkb dhruvkb added 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository labels Sep 16, 2021
Base automatically changed from active_media to main September 16, 2021 17:36
@zackkrida
Copy link
Member

@dhruvkb is the global audio player work happening here? that makes sense if so, just curious

@dhruvkb dhruvkb changed the base branch from main to global_audio November 5, 2021 11:44
@dhruvkb
Copy link
Member Author

dhruvkb commented Nov 5, 2021

@zackkrida no that's happening in the global_audio branch (no PR yet), but there are some good developments there that I wanted to use in this branch.

@dhruvkb
Copy link
Member Author

dhruvkb commented Nov 5, 2021

Also, this PR is very much a draft, the box design has changed a lot from this implementation and the states aren't documented in detail in Figma. So this will be WIP for the foreseeable future.

Base automatically changed from global_audio to main November 10, 2021 02:44
@zackkrida
Copy link
Member

@dhruvkb @panchovm Just noting here that the box states seem to be better documented now, and that this PR will also likely change based on the work in #460.

@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 9, 2021

I think I'll just close this and combine the work into #504.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boxed Audio Component
2 participants