Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update AudioTrack layouts as per new designs #504

Merged
merged 20 commits into from
Dec 14, 2021
Merged

Update AudioTrack layouts as per new designs #504

merged 20 commits into from
Dec 14, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Dec 9, 2021

Description

This PR updates the AudioTrack layouts, including subcomponents like Waveform to match the new mockups.

Changes

  • Made Waveform component extensible to seamlessly fit in different layouts
    • Fixed the Waveform border to render edge to edge with other components
    • Background can now be changed
    • Bits of UI such as duration and timestamps can be toggled
  • Added new layouts and sizes
  • Addressed focus and hover states for all AudioTrack layouts
  • Updated documentation
    • Now clearly indicates default layouts and sizes
    • Enabled Storybook Viewport addon and configured mobile views to render in mobile viewport

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🟨 priority: medium Not blocking but should be addressed soon labels Dec 9, 2021
@dhruvkb dhruvkb marked this pull request as ready for review December 12, 2021 14:17
@dhruvkb dhruvkb requested a review from a team as a code owner December 12, 2021 14:17
@dhruvkb dhruvkb requested review from krysal and obulat December 12, 2021 14:17
'dark-charcoal-60': '#837d82',
'dark-charcoal-70': '#6e686d',
'dark-charcoal-80': '#595258',
'dark-charcoal': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break so many other components. We'll need to find/replace before merging this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already did the find-and-replace.

nuxt.config.js Show resolved Hide resolved
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component looks amazing!
One question about the license icon in the Box layout: is it supposed to be hidden and only shown on hover?

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 14, 2021

@obulat the licenses appearing on hover was behaviour was confirmed by @panchovm.

@dhruvkb dhruvkb merged commit 46b412d into main Dec 14, 2021
@dhruvkb dhruvkb deleted the audio_info branch December 14, 2021 14:50
@dhruvkb dhruvkb linked an issue Dec 16, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boxed Audio Component
3 participants