-
Notifications
You must be signed in to change notification settings - Fork 63
Update AudioTrack layouts as per new designs #504
Conversation
'dark-charcoal-60': '#837d82', | ||
'dark-charcoal-70': '#6e686d', | ||
'dark-charcoal-80': '#595258', | ||
'dark-charcoal': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break so many other components. We'll need to find/replace before merging this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already did the find-and-replace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The component looks amazing!
One question about the license icon in the Box layout: is it supposed to be hidden and only shown on hover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice!
@obulat the licenses appearing on hover was behaviour was confirmed by @panchovm. |
Description
This PR updates the
AudioTrack
layouts, including subcomponents likeWaveform
to match the new mockups.Changes
Waveform
component extensible to seamlessly fit in different layoutsWaveform
border to render edge to edge with other componentsBox
layout in 3 sizes (absorbing and extending Create a box layout for the audio component #230)Full
layout (not 100% ready because Add smaller size for Download button #510)AudioTrack
layoutsTesting Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin