Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Active Media Vuex Model + Composable AudioTrack #207

Merged
merged 35 commits into from
Sep 16, 2021
Merged

Active Media Vuex Model + Composable AudioTrack #207

merged 35 commits into from
Sep 16, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Sep 13, 2021

Fixes

Fixes #182 by @zackkrida
Fixes #195 by @dhruvkb

Description

This PR

  • creates a store for holding the ID of the active media
  • automatically pauses playing media when something new plays
  • breaks down AudioTrack into AudioController (with Waveform) and PlayPause
  • enables composing these components in different layouts
  • creates 3 layouts: Full and Row (S + M)
  • creates a new component License
  • creates a new component AudioThumb (just a yellow square)

To-do

The examples show how to lay the different layouts. Work on the contents is still a WIP (especially considering that new components will be needed to display the license icon)

Screenshots

AudioTrack (feat. AudioThumb):
image

License:
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner September 13, 2021 06:10
@dhruvkb dhruvkb requested a review from obulat September 13, 2021 06:11
@dhruvkb dhruvkb marked this pull request as draft September 13, 2021 07:29
@dhruvkb dhruvkb marked this pull request as ready for review September 13, 2021 09:41
@dhruvkb dhruvkb added 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository labels Sep 13, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work.

src/components/AudioTrack/AudioThumb.vue Outdated Show resolved Hide resolved
src/components/AudioTrack/layouts/Row.vue Outdated Show resolved Hide resolved
src/components/AudioTrack/layouts/Row.vue Outdated Show resolved Hide resolved
src/components/License/License.vue Outdated Show resolved Hide resolved
src/store-modules/active-media-store.js Show resolved Hide resolved
@zackkrida zackkrida requested a review from obulat September 13, 2021 19:55
@zackkrida zackkrida mentioned this pull request Sep 14, 2021
7 tasks
@zackkrida
Copy link
Member

One more thing I noticed: the focus outline appearance is less than ideal here:

CleanShot 2021-09-13 at 20 29 01@2x

@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 14, 2021

Tagging @panchovm as this will need some input from the design perspective. My (non-professional) opinion is that the parent component should be padding the audio component when using in a full-screen context.

@zackkrida
Copy link
Member

@sarayourfriend I think this would be a good fit for you to review this week. You have a strong eye for component composition that would be appreciated here!

@sarayourfriend
Copy link
Contributor

I will take a close look at this, but it will take some time to review.

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewing the code so far, I still haven't tested it locally, but will do that next.

Overall I really like this approach 🙂

src/components/AudioTrack/AudioThumb.vue Outdated Show resolved Hide resolved
src/components/AudioTrack/AudioThumb.vue Outdated Show resolved Hide resolved
src/components/AudioTrack/AudioTrack.vue Show resolved Hide resolved
src/components/AudioTrack/PlayPause.vue Show resolved Hide resolved
src/components/AudioTrack/PlayPause.vue Show resolved Hide resolved
src/components/AudioTrack/meta/AudioTrack.stories.mdx Outdated Show resolved Hide resolved
src/store-modules/active-media-store.js Outdated Show resolved Hide resolved
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests well locally and I really like the approach you took. Nice work!

@dhruvkb dhruvkb merged commit b69efbd into main Sep 16, 2021
@dhruvkb dhruvkb deleted the active_media branch September 16, 2021 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🌟 goal: addition Addition of new feature
Projects
None yet
4 participants