-
Notifications
You must be signed in to change notification settings - Fork 63
Active Media Vuex Model + Composable AudioTrack #207
Conversation
…lement`, `AudioTrack` and `ActiveMediaStore`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work.
Tagging @panchovm as this will need some input from the design perspective. My (non-professional) opinion is that the parent component should be padding the audio component when using in a full-screen context. |
@sarayourfriend I think this would be a good fit for you to review this week. You have a strong eye for component composition that would be appreciated here! |
I will take a close look at this, but it will take some time to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewing the code so far, I still haven't tested it locally, but will do that next.
Overall I really like this approach 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tests well locally and I really like the approach you took. Nice work!
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
…into active_media
Fixes
Fixes #182 by @zackkrida
Fixes #195 by @dhruvkb
Description
This PR
AudioTrack
intoAudioController
(withWaveform
) andPlayPause
License
AudioThumb
(just a yellow square)To-do
The examples show how to lay the different layouts. Work on the contents is still a WIP (especially considering that new components will be needed to display the license icon)
Screenshots
AudioTrack
(feat.AudioThumb
):License
:Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin