Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[Feature] Abstract AudioTrack to support different UI layouts #195

Closed
1 task
dhruvkb opened this issue Sep 7, 2021 · 0 comments · Fixed by #207
Closed
1 task

[Feature] Abstract AudioTrack to support different UI layouts #195

dhruvkb opened this issue Sep 7, 2021 · 0 comments · Fixed by #207
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Sep 7, 2021

Problem

The AudioTrack component currently supports only two layouts (and that too with quite a significant bit of code repetition). Extending the same component to support many more new layouts will be complicated unless the player, waveform and play/pause facilities are abstracted and made composable.

Screenshot on 2021-09-06 at 15-34-34

Description

There needs to be a higher level of abstraction over the audio player functionality so that these three components are composable.

Additional context

This is closely related to #182 and #183 as breaking the components will need a Vuex store for handling state.

Implementation

  • 🙋 I would be interested in implementing this feature.
@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Sep 7, 2021
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon and removed 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant