This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Download translations in bulk to prevent GlotPress throttling #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2188 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: -25.6 kB (-3%) Total Size: 882 kB
ℹ️ View Unchanged
|
dhruvkb
added
🟧 priority: high
|
Success update: With the right secrets in the actions, all 200 translations are being downloaded...
...and incorporated into the Docker image.
|
zackkrida
reviewed
Feb 15, 2023
zackkrida
approved these changes
Feb 15, 2023
|
@zackkrida I'm very bad with JS Promises, even getting this PR to this usable state was very difficult for me. If you can push those changes for improved logging or fallback, that'll be very helpful. I'm considering refactoring these scripts (and maybe use TypeScript) when I have some free time because it's very difficult to work with Promise chains, at least for me if not anyone else. |
|
@dhruvkb sure, I can make some suggestions later today. |
7 tasks
|
@zackkrida my grasp on Promises was holding me back, I replaced all of that with |
…2192) Co-authored-by: Zack Krida <zackkrida@pm.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2184 by @dhruvkb
Description
This PR adds bulk downloading for translations by logging into GlotPress, downloading the ZIP and extracting the JSON content. It reuses the existing framework for massaging them from
jed1xto Vue i18n's format and then writing them to the destination dir.If GlotPress credentials are not present in the environment, the old throttled approach will be used as the fallback, a Make WordPress membership is not needed for development.
Other improvements
la.json) too. Unfortuanately we can't use it because it's not in the valid locales list.locales-list.jsonthat was not being used anywhere and had no references pointing to it.Testing Instructions
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin