This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Reduce GlotPress limit further to ensure all languages #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2184 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
github-actions
bot
added
the
🚦 status: awaiting triage
dhruvkb
added
🟧 priority: high
|
Size Change: 0 B Total Size: 908 kB ℹ️ View Unchanged
|
github-actions
bot
added
the
🚦 status: awaiting triage
dhruvkb
removed
the
🚦 status: awaiting triage
zackkrida
approved these changes
Feb 14, 2023
|
@dhruvkb,I was made aware of two bulk endpoints we can use for this. However, they require authentication.
I think this will help considerably! |
|
We can use the authenticated endpoint for CI, GitHub actions and maybe prod deployments but developers working locally will not have access to these endpoints unless they sign up for Make. I would very much prefer to not complicate the dev setup to add a Make account prerequisite. All that is to say, we could keep both the throttled code and the authenticated code and use one based on whether keys are present. |
|
I've merged this, and opened a new issue WordPress/openverse#451 to handle bulk downloading. |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2170 by @AetherUnbound by improving #2172 by @dhruvkb
Description
Even with the limit of 99 requests per second, the GlotPress download reports several 429 errors. This was not happening when the PR #2172 was made but it's happening now, because of which staging.openverse.org again lacks some languages. The situation is better, we have ~150 languages now but still not all of them (~200).
Testing Instructions
This PR reduces the rate limit even further. It would be better if GlotPress had some official documentation around rate limits. Alternatively we could fail the deploy if the download step is incomplete?
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin