This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Simplify get-translations.js and add error handling and fallbacks
#2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2192 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
dhruvkb
changed the title
get-translations.js and add error handling and fallbacks
7 tasks
dhruvkb
added
🟧 priority: high
|
Size Change: 0 B Total Size: 908 kB ℹ️ View Unchanged
|
zackkrida
suggested changes
Feb 16, 2023
There was a problem hiding this comment.
I'll review more deeply for code quality, but when I switch locales I'm seeing english, and noticed items in the translation files look like this:
"filters.audio-categories.sound_effect\u0004Sound effects": {
"0": "Efectos de sonido"
},Where the en.json equivalent is:
"audio-categories": {
"title": "Audio category",
"audiobook": "Audiobook",
"music": "Music",
"news": "News",
"podcast": "Podcast",
"pronunciation": "Pronunciation",
"sound_effect": "Sound effects",
"sound": "Sound effects"
},
|
I'll debug that immediately. Update: I was missing a step. Fixed in 195bfb3. |
zackkrida
reviewed
Feb 16, 2023
|
Playwright Failure Test Results It looks like some of the Playwright tests failed. You can download the Playwright trace https://github.com/WordPress/openverse-frontend/actions/runs/4197079922 Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging |
zackkrida
approved these changes
Feb 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves upon #2188 in the following ways
get-translations.jsfile into smaller files that work independently--require-completethat can be passed to halt builds when the translations are incompletely downloaded.All in all, this PR adds significant resilience to the multi-pronged approach developed in #2188.
Testing Instructions
src/locales/scripts/axios.js--require-completeflagChecklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin