This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add the new VR tests with new_header flag turned on
#1919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1919 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
obulat
force-pushed
the
add/new_vr_tests
branch
from
32d7586 to
9693f42
Compare
|
Size Change: -2.13 kB (0%) Total Size: 813 kB
ℹ️ View Unchanged
|
obulat
commented
Oct 18, 2022
src/pages/search/audio.vue
Outdated
| @@ -69,7 +71,7 @@ export default defineComponent({ | |||
|
|
|||
| const results = computed(() => props.resultItems.audio) | |||
|
|
|||
| const isMinScreenMd = isMinScreen('md', { shouldPassInSSR: true }) | |||
| const isMinScreenMd = inject(IsMinScreenMdKey) | |||
There was a problem hiding this comment.
Using the injected isMinScreenMd ensures that all the tailwind classes are updated to md and up when the app is hydrated. You can see the changes in audio-results-old snapshots with desktop UA: the layout is correct and the play button is exactly on the thumbnail instead of below it.
obulat
force-pushed
the
add/new_vr_tests
branch
from
9693f42 to
130cc25
Compare
obulat
force-pushed
the
update_pw_helpers
branch
from
16c3db0 to
b73ace1
Compare
obulat
force-pushed
the
add/new_vr_tests
branch
11 times, most recently
from
28798f1 to
b43b813
Compare
obulat
force-pushed
the
add/new_vr_tests
branch
5 times, most recently
from
852a4e9 to
6e00f3a
Compare
Remove the Chrome search input cross in tailwind.css Extract changes from #1930 Update snapshots Fix the search button
obulat
force-pushed
the
add/new_vr_tests
branch
from
6e00f3a to
ce749b6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #1843 by @dhruvkb
Description
This PR was originally created to add new visual regression tests for pages and components when
new_headerflag is turned on. So, it fixes thedescribeEachMobilebreakpoint testing function to includemd(as now it's using the mobile layout, not the desktop one) and adds the new tests.However, while working on it, I also found other changes that needed to be updated. I recently set
maxDiffPixelRatioin Playwright config to 0.06 out of frustration with the flaky component tests, when if a component shifted 1 px down, the test was failing. When I set it back to the previous value of 0.02, I saw a lot of small changes that have crept up intomainrecently :(self-centerclass to it. The problem was that the class was added to the baseVButtoncomponent, which affected other buttons (e.g., the Copy button inside the license panel became centered) - This is fixed in Fix VButton centering #1930oldheader became taller (50px instead of 48px) because the Openverse Logo changed its height to 50px, and the buttons stretched to the full height of the logo.descriptionclass instead ofdescription-bold.Testing Instructions
The CI should pass, and the snapshots should look well and match the designs.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin