Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add E2E and VRT tests for new header and footer #1843

Closed
6 tasks done
dhruvkb opened this issue Sep 22, 2022 · 1 comment
Closed
6 tasks done

Add E2E and VRT tests for new header and footer #1843

dhruvkb opened this issue Sep 22, 2022 · 1 comment
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Sep 22, 2022

Problem

The new header and footer are being developed behind a feature flag which makes it harder to write E2E and VRT test cases for them. This is being addressed in #1837.

Description

Once #1837 is resolved, tests need to be added for the following components.

Alternatives

Snapshot testing for components (not pages) should be done from Storybook wherever feasible. This would enable us to snapshot all the different states of a component and see them in isolation, independently of the other stuff on the page. Hopefully, it will also make the snaps more resilient to small shifts and make it easier to pinpoint the change if the snapshots do not line up.

Implementation

  • 🙋 I would be interested in implementing this feature.
@dhruvkb dhruvkb added enhancement help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository ⛔ status: blocked Blocked & therefore, not ready for work labels Sep 22, 2022
@dhruvkb dhruvkb added this to the Create new header and footer milestone Sep 22, 2022
@dhruvkb dhruvkb removed the ⛔ status: blocked Blocked & therefore, not ready for work label Sep 27, 2022
@dhruvkb dhruvkb self-assigned this Sep 27, 2022
@obulat
Copy link
Contributor

obulat commented Oct 18, 2022

This issue should also include the work on updating the existing tests to pass with the new_header enabled.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

No branches or pull requests

2 participants