This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add E2E and VRT tests for new header and footer #1843
Labels
💻 aspect: code
Concerns the software code in the repository
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
help wanted
Open to participation from the community
🟧 priority: high
Stalls work on the project or its dependents
Milestone
Problem
The new header and footer are being developed behind a feature flag which makes it harder to write E2E and VRT test cases for them. This is being addressed in #1837.
Description
Once #1837 is resolved, tests need to be added for the following components.
VHeaderInternal
- Storybook VR tests added in Add VHeaderInternal #1825VHeaderContent
- Playwright VR tests added in Add VR tests for mobile search header #1968VFooter
- Storybook VR tests added in Add VFooter Storybook VR tests #1969VSelectField
- Storybook VR tests added in Create locale chooserVLanguage
and place in the footer #1821VLanguageSelect
- Storybook VR tests added in Create locale chooserVLanguage
and place in the footer #1821Alternatives
Snapshot testing for components (not pages) should be done from Storybook wherever feasible. This would enable us to snapshot all the different states of a component and see them in isolation, independently of the other stuff on the page. Hopefully, it will also make the snaps more resilient to small shifts and make it easier to pinpoint the change if the snapshots do not line up.
Implementation
The text was updated successfully, but these errors were encountered: