This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Update Playwright tests utilities to work both when the new_header flag is enabled and when it's disabled
#1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1914 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: -3.3 kB (0%) Total Size: 820 kB
ℹ️ View Unchanged
|
obulat
force-pushed
the
update_pw_helpers
branch
from
0719234 to
bd8da8b
Compare
obulat
changed the title
new_header flag is enabled and when it's disabled
7 tasks
obulat
commented
Oct 18, 2022
obulat
added
🟧 priority: high
zackkrida
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
I'm not always a huge fan of "old" and "new" as indicators for things like this. Whatever is "new" today eventually becomes old. I guess at that point we'd come back and refactor all of these to remove the "old" tests... but to someone reading this who isn't clued into the header work, these mode names are cryptic. Are there clearer names than new and old for the mode? Maybe even "new_header" or "old_header"?
Also, one nit, if we could extract the 'old' | 'new' type out it would help with the eventual "delete the old mode" refactor... if you removed the shared type then TypeScript would tell you precisely everywhere that needed to be changed to accommodate the refactor 🙂
Also, one nit, if we could extract the 'old' | 'new' type out it would help with the eventual "delete the old mode" refactor... if you removed the shared type then TypeScript would tell you precisely everywhere that needed to be changed to accommodate the refactor 🙂 Great suggestions, thank you, @sarayourfriend! I've added the new type, and made |
Rename the tests that use utils functions adding `-old` Update test/playwright/utils/navigation.ts Create a `HeaderMode` type, and set values to 'new_header'/'old_header'
obulat
force-pushed
the
update_pw_helpers
branch
from
16c3db0 to
b73ace1
Compare
sarayourfriend
approved these changes
Oct 19, 2022
obulat
added a commit
that referenced
this pull request
Oct 26, 2022
…flag is enabled and when it's disabled (#1914) Add e2e test utils for new_header Rename the tests that use utils functions adding `-old` Update test/playwright/utils/navigation.ts Create a `HeaderMode` type, and set values to 'new_header'/'old_header'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #1843 by @dhruvkb
Description
This PR prepares the background for the tests with
new_headerenabled:utilsmethods to add themodeparameter. By default, it is set tonew, and all the functions work with thenew_header. The previous functions are used whenmodeparameter is set toold.utilsmethods to add-oldsuffix to them. The new tests without the suffix will be added in a follow-up PR.mdbreakpoint, and now they start atlg.VContentSettingsButtonto add a number of filters applied.Testing Instructions
The tests in CI should pass.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin