This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1930 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
🕹 aspect: interface
Concerns end-users' experience with the software
🛠 goal: fix
Bug fix
🟧 priority: high
Stalls work on the project or its dependents
labels
Oct 20, 2022
7 tasks
obulat
added a commit
that referenced
this pull request
Oct 20, 2022
Size Change: -1.4 kB (0%) Total Size: 822 kB
ℹ️ View Unchanged
|
dhruvkb
approved these changes
Oct 21, 2022
krysal
approved these changes
Oct 21, 2022
obulat
added a commit
that referenced
this pull request
Oct 21, 2022
obulat
added a commit
that referenced
this pull request
Oct 21, 2022
Remove the Chrome search input cross in tailwind.css Move the `self-center` class to weblink button Add updated snapshots Extract changes from #1930
obulat
added a commit
that referenced
this pull request
Oct 25, 2022
Remove the Chrome search input cross in tailwind.css Move the `self-center` class to weblink button Add updated snapshots Extract changes from #1930
obulat
added a commit
that referenced
this pull request
Oct 25, 2022
Remove the Chrome search input cross in tailwind.css Move the `self-center` class to weblink button Add updated snapshots Extract changes from #1930
obulat
added a commit
that referenced
this pull request
Oct 27, 2022
Remove the Chrome search input cross in tailwind.css Move the `self-center` class to weblink button Add updated snapshots Extract changes from #1930
obulat
added a commit
that referenced
this pull request
Oct 28, 2022
Remove the Chrome search input cross in tailwind.css Move the `self-center` class to weblink button Add updated snapshots Extract changes from #1930
obulat
added a commit
that referenced
this pull request
Oct 28, 2022
Remove the Chrome search input cross in tailwind.css Move the `self-center` class to weblink button Add updated snapshots Extract changes from #1930 Update snapshots Try fixing the search button Simplify the search button Simplify the search button
obulat
added a commit
that referenced
this pull request
Oct 28, 2022
Remove the Chrome search input cross in tailwind.css Extract changes from #1930 Update snapshots Fix the search button
obulat
added a commit
that referenced
this pull request
Oct 28, 2022
Remove the Chrome search input cross in tailwind.css Extract changes from #1930 Update snapshots Fix the search button
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🕹 aspect: interface
Concerns end-users' experience with the software
🛠 goal: fix
Bug fix
🟧 priority: high
Stalls work on the project or its dependents
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1929 by @obulat
Description
This PR moves
self-center
class for fixing the CTA button fromVButton
component to the parent components of the CTA button.Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin