This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Split VHeader into VHeaderDesktop and VHeaderMobile components #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1845 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
🟧 priority: high
|
Size Change: -7.81 kB (-1%) Total Size: 810 kB
ℹ️ View Unchanged
|
|
My comment about toggling between the headers with CSS only applies here too, but once we make a decision on that this looks great. |
obulat
force-pushed
the
cleanup_header_components
branch
from
410abfc to
41abdf8
Compare
|
@obulat could you update the description to include what are intentional changes here, and what are temporary omissions or visual bugs that will be rectified after merge? It's looking really great based on what I think is supposed to be happening but I have a few things I'm not sure about. I think I can give this an approving review after getting some more information. |
I've actually split this PR into several others: VSearchTypeButton (#1860), VFilterButton (#1861) and the cleanup of the components used for the search type popup/modal (#1842). So, I'm converting this PR to draft and will update it after those PRs are done. |
zackkrida
requested review from
dhruvkb
and removed request for
sarayourfriend
obulat
force-pushed
the
cleanup_header_components
branch
4 times, most recently
from
403fd17 to
0259963
Compare
obulat
changed the title
obulat
force-pushed
the
cleanup_header_components
branch
3 times, most recently
from
8566b41 to
9ba30c0
Compare
dhruvkb
approved these changes
Sep 29, 2022
obulat
force-pushed
the
cleanup_header_components
branch
2 times, most recently
from
59f504c to
0da45e6
Compare
obulat
force-pushed
the
cleanup_header_components
branch
from
32181de to
6ddc9b6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1830 by @sarayourfriend
Description
This PR creates a two components for search page mobile/desktop headers:
VHeaderMobile(untillg) andVHeaderDesktop.It also removes the remaining components that cause the warning about duplicate components during the Nuxt build (
VMobileMenuModal,VHeaderFilter,VHeaderMenu).This is not creating the actual mobile header or the desktop header according to mockups. The main goal is to remove duplicate and unnecessary components, and to set the basis for future desktop and mobile header implementations.
Testing Instructions
No components break without the
new_headerflag set on. So, the CI passing should be enough.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin