Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add the desktop header #1869

Closed
wants to merge 6 commits into from
Closed

Add the desktop header #1869

wants to merge 6 commits into from

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 28, 2022

Fixes

Fixes #[issue number] by @[issue author]

Description

This PR combines 3 PRs to create the new desktop search page header: #1845, #1860, and #1861.
There are 2 more things we'd need to do for the desktop header to be ready:

  • Fix the content switcher popover content alignment
  • Add the 'recent searches' popover.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat changed the title Add/header desktop Add the desktop header Sep 28, 2022
@github-actions
Copy link

github-actions bot commented Sep 28, 2022 •
edited
Loading

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/1869
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1869/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Sep 28, 2022
@github-actions
Copy link

Size Change: -4.04 kB (0%)

Total Size: 812 kB

Filename Size Change
./.nuxt/dist/client/236.js 0 B -273 B (removed) 🏆
./.nuxt/dist/client/236.modern.js 0 B -277 B (removed) 🏆
./.nuxt/dist/client/237.js 0 B -1.85 kB (removed) 🏆
./.nuxt/dist/client/app.js 127 kB -1.41 kB (-1%)
./.nuxt/dist/client/app.modern.js 119 kB -1.31 kB (-1%)
./.nuxt/dist/client/commons/app.js 88.1 kB -15 B (0%)
./.nuxt/dist/client/commons/app.modern.js 77 kB -16 B (0%)
./.nuxt/dist/client/components/v-content-settings-button.js 0 B -691 B (removed) 🏆
./.nuxt/dist/client/components/v-content-settings-button.modern.js 0 B -694 B (removed) 🏆
./.nuxt/dist/client/components/v-sources-table.js 15.2 kB +110 B (+1%)
./.nuxt/dist/client/components/v-sources-table.modern.js 15.2 kB +107 B (+1%)
./.nuxt/dist/client/runtime.js 2.68 kB -59 B (-2%)
./.nuxt/dist/client/runtime.modern.js 2.68 kB -60 B (-2%)
./.nuxt/dist/client/vendors/app.modern.js 47.1 kB +17 B (0%)
./.nuxt/dist/client/227.js 272 B +272 B (new file) 🆕
./.nuxt/dist/client/227.modern.js 277 B +277 B (new file) 🆕
./.nuxt/dist/client/228.js 1.85 kB +1.85 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./.nuxt/dist/client/components/loading-icon.js 747 B +2 B (0%)
./.nuxt/dist/client/components/loading-icon.modern.js 751 B -2 B (0%)
./.nuxt/dist/client/components/table-sort-icon.js 508 B 0 B
./.nuxt/dist/client/components/table-sort-icon.modern.js 512 B -1 B (0%)
./.nuxt/dist/client/components/v-all-results-grid.js 2.78 kB +2 B (0%)
./.nuxt/dist/client/components/v-all-results-grid.modern.js 2.75 kB -2 B (0%)
./.nuxt/dist/client/components/v-all-results-grid/pages/search/audio/pages/search/index.js 3.02 kB +1 B (0%)
./.nuxt/dist/client/components/v-all-results-grid/pages/search/audio/pages/search/index.modern.js 2.92 kB -4 B (0%)
./.nuxt/dist/client/components/v-audio-cell.js 357 B +1 B (0%)
./.nuxt/dist/client/components/v-audio-cell.modern.js 360 B -1 B (0%)
./.nuxt/dist/client/components/v-audio-details.js 1.81 kB -1 B (0%)
./.nuxt/dist/client/components/v-audio-details.modern.js 1.79 kB +1 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB +1 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.01 kB -2 B (0%)
./.nuxt/dist/client/components/v-audio-track.js 5.11 kB -4 B (0%)
./.nuxt/dist/client/components/v-audio-track.modern.js 5.05 kB +3 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.js 569 B 0 B
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 573 B -1 B (0%)
./.nuxt/dist/client/components/v-bone.js 684 B 0 B
./.nuxt/dist/client/components/v-bone.modern.js 689 B 0 B
./.nuxt/dist/client/components/v-box-layout.js 1.2 kB +1 B (0%)
./.nuxt/dist/client/components/v-box-layout.modern.js 1.2 kB -1 B (0%)
./.nuxt/dist/client/components/v-content-link.js 1.13 kB +1 B (0%)
./.nuxt/dist/client/components/v-content-link.modern.js 1.11 kB -2 B (0%)
./.nuxt/dist/client/components/v-content-page.js 466 B 0 B
./.nuxt/dist/client/components/v-content-page.modern.js 471 B 0 B
./.nuxt/dist/client/components/v-content-report-button.js 766 B +1 B (0%)
./.nuxt/dist/client/components/v-content-report-button.modern.js 772 B -1 B (0%)
./.nuxt/dist/client/components/v-content-report-form.js 3.77 kB -4 B (0%)
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.58 kB +1 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.js 4.45 kB -3 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.26 kB +3 B (0%)
./.nuxt/dist/client/components/v-copy-button.js 3.97 kB +1 B (0%)
./.nuxt/dist/client/components/v-copy-button.modern.js 3.98 kB +3 B (0%)
./.nuxt/dist/client/components/v-copy-license.js 2.95 kB +1 B (0%)
./.nuxt/dist/client/components/v-copy-license.modern.js 2.93 kB +1 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js 9.68 kB +3 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js 9.66 kB +2 B (0%)
./.nuxt/dist/client/components/v-dmca-notice.js 748 B -1 B (0%)
./.nuxt/dist/client/components/v-dmca-notice.modern.js 753 B +4 B (+1%)
./.nuxt/dist/client/components/v-error-image.js 1.69 kB +3 B (0%)
./.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB 0 B
./.nuxt/dist/client/components/v-error-section.js 373 B +1 B (0%)
./.nuxt/dist/client/components/v-error-section.modern.js 377 B +2 B (+1%)
./.nuxt/dist/client/components/v-full-layout.js 1.47 kB -3 B (0%)
./.nuxt/dist/client/components/v-full-layout.modern.js 1.48 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.js 1.6 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.61 kB -3 B (0%)
./.nuxt/dist/client/components/v-image-cell-square.js 1.01 kB 0 B
./.nuxt/dist/client/components/v-image-cell-square.modern.js 1.02 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-cell.js 1.43 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-cell.modern.js 1.42 kB 0 B
./.nuxt/dist/client/components/v-image-details.js 1.44 kB 0 B
./.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB 0 B
./.nuxt/dist/client/components/v-image-grid.js 2.53 kB -3 B (0%)
./.nuxt/dist/client/components/v-image-grid.modern.js 2.42 kB 0 B
./.nuxt/dist/client/components/v-license-tab-panel.js 922 B +1 B (0%)
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 920 B +2 B (0%)
./.nuxt/dist/client/components/v-load-more.js 787 B 0 B
./.nuxt/dist/client/components/v-load-more.modern.js 684 B -1 B (0%)
./.nuxt/dist/client/components/v-media-license.js 800 B +2 B (0%)
./.nuxt/dist/client/components/v-media-license.modern.js 809 B +2 B (0%)
./.nuxt/dist/client/components/v-media-reuse.js 1.08 kB -1 B (0%)
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.08 kB 0 B
./.nuxt/dist/client/components/v-media-reuse/pages/image/_id.js 2.95 kB +1 B (0%)
./.nuxt/dist/client/components/v-media-reuse/pages/image/_id.modern.js 2.93 kB +1 B (0%)
./.nuxt/dist/client/components/v-media-tag.js 430 B 0 B
./.nuxt/dist/client/components/v-media-tag.modern.js 434 B 0 B
./.nuxt/dist/client/components/v-meta-search-form.js 3.1 kB -1 B (0%)
./.nuxt/dist/client/components/v-meta-search-form.modern.js 3.07 kB -1 B (0%)
./.nuxt/dist/client/components/v-meta-source-list.js 2.56 kB -1 B (0%)
./.nuxt/dist/client/components/v-meta-source-list.modern.js 2.54 kB +1 B (0%)
./.nuxt/dist/client/components/v-no-results.js 2.76 kB -4 B (0%)
./.nuxt/dist/client/components/v-no-results.modern.js 2.74 kB +1 B (0%)
./.nuxt/dist/client/components/v-radio.js 1.51 kB 0 B
./.nuxt/dist/client/components/v-radio.modern.js 1.47 kB 0 B
./.nuxt/dist/client/components/v-related-audio.js 1.23 kB +2 B (0%)
./.nuxt/dist/client/components/v-related-audio.modern.js 1.23 kB -3 B (0%)
./.nuxt/dist/client/components/v-related-images.js 3.09 kB -1 B (0%)
./.nuxt/dist/client/components/v-related-images.modern.js 2.98 kB -1 B (0%)
./.nuxt/dist/client/components/v-report-desc-form.js 965 B -1 B (0%)
./.nuxt/dist/client/components/v-report-desc-form.modern.js 965 B 0 B
./.nuxt/dist/client/components/v-row-layout.js 1.68 kB -1 B (0%)
./.nuxt/dist/client/components/v-row-layout.modern.js 1.69 kB +2 B (0%)
./.nuxt/dist/client/components/v-scroll-button.js 813 B 0 B
./.nuxt/dist/client/components/v-scroll-button.modern.js 818 B -1 B (0%)
./.nuxt/dist/client/components/v-search-grid.js 5.45 kB 0 B
./.nuxt/dist/client/components/v-search-grid.modern.js 5.39 kB +1 B (0%)
./.nuxt/dist/client/components/v-search-results-title.js 656 B -2 B (0%)
./.nuxt/dist/client/components/v-search-results-title.modern.js 653 B +1 B (0%)
./.nuxt/dist/client/components/v-search-type-radio.js 830 B -1 B (0%)
./.nuxt/dist/client/components/v-search-type-radio.modern.js 820 B 0 B
./.nuxt/dist/client/components/v-server-timeout.js 298 B 0 B
./.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 995 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 894 B +1 B (0%)
./.nuxt/dist/client/components/v-skip-to-content-container.js 887 B 0 B
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 893 B -2 B (0%)
./.nuxt/dist/client/components/v-snackbar.js 1.18 kB 0 B
./.nuxt/dist/client/components/v-snackbar.modern.js 1.19 kB -1 B (0%)
./.nuxt/dist/client/components/v-tab-panel.js 688 B 0 B
./.nuxt/dist/client/components/v-tab-panel.modern.js 684 B 0 B
./.nuxt/dist/client/components/v-tab.js 1.73 kB +4 B (0%)
./.nuxt/dist/client/components/v-tab.modern.js 1.72 kB -4 B (0%)
./.nuxt/dist/client/components/v-tabs.js 779 B 0 B
./.nuxt/dist/client/components/v-tabs.modern.js 766 B +1 B (0%)
./.nuxt/dist/client/components/v-warning-suppressor.js 299 B +1 B (0%)
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 303 B 0 B
./.nuxt/dist/client/pages/about.js 1.06 kB +1 B (0%)
./.nuxt/dist/client/pages/about.modern.js 1.06 kB +1 B (0%)
./.nuxt/dist/client/pages/audio/_id.js 6.63 kB -1 B (0%)
./.nuxt/dist/client/pages/audio/_id.modern.js 6.46 kB 0 B
./.nuxt/dist/client/pages/feedback.js 3.23 kB +1 B (0%)
./.nuxt/dist/client/pages/feedback.modern.js 3.21 kB 0 B
./.nuxt/dist/client/pages/image/_id.js 6.99 kB -6 B (0%)
./.nuxt/dist/client/pages/image/_id.modern.js 6.77 kB +3 B (0%)
./.nuxt/dist/client/pages/index.js 5.05 kB -3 B (0%)
./.nuxt/dist/client/pages/index.modern.js 4.94 kB +3 B (0%)
./.nuxt/dist/client/pages/meta-search.js 1.67 kB +4 B (0%)
./.nuxt/dist/client/pages/meta-search.modern.js 1.67 kB +1 B (0%)
./.nuxt/dist/client/pages/preferences.js 1.21 kB 0 B
./.nuxt/dist/client/pages/preferences.modern.js 1.21 kB +1 B (0%)
./.nuxt/dist/client/pages/search-help.js 1.54 kB 0 B
./.nuxt/dist/client/pages/search-help.modern.js 1.55 kB 0 B
./.nuxt/dist/client/pages/search.js 2.73 kB -3 B (0%)
./.nuxt/dist/client/pages/search.modern.js 2.58 kB -2 B (0%)
./.nuxt/dist/client/pages/search/audio.js 1.19 kB -4 B (0%)
./.nuxt/dist/client/pages/search/audio.modern.js 1.2 kB +2 B (0%)
./.nuxt/dist/client/pages/search/image.js 2.78 kB -5 B (0%)
./.nuxt/dist/client/pages/search/image.modern.js 2.67 kB -1 B (0%)
./.nuxt/dist/client/pages/search/index.js 2.99 kB +2 B (0%)
./.nuxt/dist/client/pages/search/index.modern.js 2.96 kB -3 B (0%)
./.nuxt/dist/client/pages/search/model-3d.js 242 B 0 B
./.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.modern.js 270 B 0 B
./.nuxt/dist/client/pages/search/video.js 239 B +1 B (0%)
./.nuxt/dist/client/pages/search/video.modern.js 243 B 0 B
./.nuxt/dist/client/pages/sources.js 1.44 kB -1 B (0%)
./.nuxt/dist/client/pages/sources.modern.js 1.45 kB 0 B
./.nuxt/dist/client/vendors/app.js 47.8 kB +3 B (0%)

compressed-size-action

@github-actions
Copy link

Playwright Failure Test Results

It looks like some of the Playwright tests failed. You can download the Playwright trace
output for both Storybook and Nuxt Playwright tests that have failed at the bottom of this
page, under the "Artifacts" section:

https://github.com/WordPress/openverse-frontend/actions/runs/3141443490

Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging

@obulat
Copy link
Contributor Author

obulat commented Oct 4, 2022

Closing this PR as all the changes have already been added to main.

@obulat obulat closed this Oct 4, 2022
@obulat obulat deleted the add/header_desktop branch October 26, 2022 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obulat @openverse-bot