This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Refactor SearchTypePopover desktop header #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1842 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
✨ goal: improvement
|
Size Change: -185 B (0%) Total Size: 814 kB
ℹ️ View Unchanged
|
obulat
commented
Sep 21, 2022
zackkrida
suggested changes
Sep 22, 2022
There was a problem hiding this comment.
- The search bar in VHeaderDesktop appears to fill all available space; is that the correct behavior or is it meant to have a max-width?
- I don't think it matters since this will be replaced, but there's a slight alignment problem in a medium breakpoint:
<div class="hidden lg:block">
<VHeaderDesktop />
</div>
<div class="block lg:hidden">
<VHeader />
</div>
7 tasks
The main goal of this PR is to get rid of the components that have duplicate names, and to separate the two
The current solution has the following downsides:
There are a couple of downsides to this CSS solution:
I was mainly trying to optimize for the mobile experience/performance because mobile usually has lower bandwidths. Do you think it's better to use CSS, @zackkrida, and reduce the need for JS hacks? |
|
@obulat I think we can follow your solution instead of a CSS approach. We can use the session cookie approach later to fix any visual flashes. Your point about the bundle size is a good one. |
zackkrida
approved these changes
Sep 26, 2022
obulat
force-pushed
the
add/desktop_content_settings
branch
from
12acc1e to
0ba8a51
Compare
obulat
changed the title
dhruvkb
approved these changes
Sep 29, 2022
| }" | ||
| aria-hidden="true" | ||
| :data-prefers-reduced-motion="prefersReducedMotion" | ||
| data-testid="logo-loader" | ||
| class="inline-flex h-12 w-12 items-center justify-center rounded p-3 md:h-12 md:w-12" | ||
| class="inline-flex items-center justify-center rounded p-3 md:h-12 md:w-12" |
There was a problem hiding this comment.
Do the md: height and width classes not need to be moved?
There was a problem hiding this comment.
Moved to the beginning of the class list? I think the prefixed classes are always at the end.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1836 by @obulat
Description
This PR creates a
VHeaderDesktopcomponent that will be used on widths abovelg. It refactors theVSearchTypePopoverto only open the popover (so, it removes the modal). It also refactors the desktop filters button to only open the sidebar.This PR adds an
IsMinScreenLgprovidevalue in thedefault.vuelayout that is set to true only after the layout was mounted. This enables us to have components rendered conditionally (withv-if) without getting the server and client mismatch on rendering.Testing Instructions
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin