Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

updates all the outdated testing-related dev deps #1217

Closed
wants to merge 4 commits into from

Conversation

kb-0311
Copy link
Contributor

@kb-0311 kb-0311 commented Apr 1, 2022

Fixes

Fixes #1086 by @krysal

Description

Updates these outdated dev dependencies to the following versions ->

"@pinia/testing": "^0.0.11",
"@testing-library/user-event": "^14.0.4",
"@testing-library/vue": "^6.5.1",
"@types/jest": "^27.4.1",
"@vue/test-utils": "^2.0.0-rc.17",
"babel-jest": "^27.5.1",
"eslint-plugin-unicorn": "^42.0.0",
"jest": "^27.5.1",

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@kb-0311 kb-0311 requested a review from a team as a code owner April 1, 2022 14:56
@kb-0311 kb-0311 requested review from obulat and dhruvkb April 1, 2022 14:56
@openverse-bot openverse-bot added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon labels Apr 1, 2022
@kb-0311
Copy link
Contributor Author

kb-0311 commented Apr 1, 2022

Hmmm, the unit test is failing once again is it some error on my end, or is it the same issue @obulat mentioned we are facing?

Because again the unit test fails but the E2E test passes....

If it is an error on my part please suggest the changes I can make. Thanks.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these packages are changing major versions here so there are expected to be breaking changes and modifications to test code. For example, it would be good to update jest and babel-jest but could be a big task to address all the changes.

You can try going by the changlogs, see what is breaking, and try to fix it or update @testing-library related packages first, those should be a straightforward process without much complication.

package.json Outdated
"@types/module-alias": "^2.0.1",
"@types/uuid": "^8.3.4",
"@typescript-eslint/eslint-plugin": "^5.15.0",
"@typescript-eslint/parser": "^5.15.0",
"@vue/runtime-dom": "^3.2.31",
"@vue/test-utils": "^1.1.3",
"@vue/test-utils": "^2.0.0-rc.17",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't update @vue/test-utils to v2.x because it targets Vue 3 and Nuxt depends on Vue 2 currently.

@kb-0311 kb-0311 closed this Apr 1, 2022
@kb-0311
Copy link
Contributor Author

kb-0311 commented Apr 1, 2022

closing this one to update the libraries one by one in another PR #1222

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated dependencies
3 participants