Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update ESLint-related plugins and @pinia/testing #1222

Merged
merged 10 commits into from
Apr 5, 2022

Conversation

kb-0311
Copy link
Contributor

@kb-0311 kb-0311 commented Apr 1, 2022

Fixes

Fixes #1086 by @krysal

Description

updates dev dependencies ->

"@pinia/testing": "^0.0.11",
"@testing-library/user-event": "^13.5.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-unicorn": "^42.0.0",
"@typescript-eslint/eslint-plugin": "^5.17.0",
"@typescript-eslint/parser": "^5.17.0",

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@kb-0311 kb-0311 requested a review from a team as a code owner April 1, 2022 19:19
@kb-0311 kb-0311 requested review from obulat and sarayourfriend April 1, 2022 19:19
@openverse-bot openverse-bot added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon labels Apr 1, 2022
@kb-0311 kb-0311 changed the title updated jest and babel-jest updated @testing-library Apr 1, 2022
@kb-0311
Copy link
Contributor Author

kb-0311 commented Apr 1, 2022

I closed the previous PR and updated the testing library first but after updating jest and babel-jest gave the same error.

WIll updating @types-jest solve the issue, maybe ?

@kb-0311
Copy link
Contributor Author

kb-0311 commented Apr 2, 2022

It seems there are some breaking changes with a lot of testing library updates, jest and babel-jest with the current versions of webpack, Nuxt and Vue.

I am changing this PR to update only @pinia/testing and in future I will commit the updates for some others eslint related dev deps in this PR itself.

@kb-0311 kb-0311 changed the title updated @testing-library updated eslint-related plugins and @pinia/testing Apr 2, 2022
@kb-0311
Copy link
Contributor Author

kb-0311 commented Apr 2, 2022

Hey So I have left out the testing-related dev deps as is , because of a lot of compatibility issues and breaking changes with jest update itself and instead this PR now updates all the eslint related plugins and dev deps.

Thank you, and please review it when you get the time 😄

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates, and for making this PR so easy to review, @kb-0311 !
It seems to have removed quite a few of dependencies of dependencies, a nice bonus 🎉

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing tests are a pretty good indicator! Good PR @kb-0311!

@dhruvkb dhruvkb changed the title updated eslint-related plugins and @pinia/testing Update ESLint-related plugins and @pinia/testing Apr 5, 2022
@dhruvkb dhruvkb merged commit d106d9a into WordPress:main Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated dependencies
4 participants