-
Notifications
You must be signed in to change notification settings - Fork 63
Update ESLint-related plugins and @pinia/testing #1222
Conversation
I closed the previous PR and updated the testing library first but after updating jest and babel-jest gave the same error. WIll updating |
It seems there are some breaking changes with a lot of I am changing this PR to update only |
Hey So I have left out the testing-related dev deps as is , because of a lot of compatibility issues and breaking changes with jest update itself and instead this PR now updates all the Thank you, and please review it when you get the time 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates, and for making this PR so easy to review, @kb-0311 !
It seems to have removed quite a few of dependencies of dependencies, a nice bonus 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing tests are a pretty good indicator! Good PR @kb-0311!
Fixes
Fixes #1086 by @krysal
Description
updates dev dependencies ->
Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin