Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update @intlify/eslint-plugin-vue-i18n, vue-tsc & lint-staged #1215

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

kb-0311
Copy link
Contributor

@kb-0311 kb-0311 commented Apr 1, 2022

Fixes

Fixes #1086 by @krysal

Description

updates dev dependencies

"@intlify/eslint-plugin-vue-i18n": "^1.4.0",
"lint-staged": "^12.3.7",
"vue-tsc": "^0.33.9"

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@kb-0311 kb-0311 requested a review from a team as a code owner April 1, 2022 12:50
@kb-0311 kb-0311 requested review from krysal and obulat April 1, 2022 12:50
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Apr 1, 2022
@kb-0311
Copy link
Contributor Author

kb-0311 commented Apr 1, 2022

Hmm seems there is some e2e error with the search query parameter for audio/video.

There also seems to be this warning here ->
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).

Are there anyways to resolve the error AND increase the asset size limit ?

Edit : It passed the playwright test now, strange .

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-ran the playwright tests, and they pass. There is some flakiness in our current tests, unfortunately, which can sometimes cause tests to fail even though there is no actual problem.

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This is just a warning, and it does not cause errors in the CI checks.

Thank you for your contribution, @kb-0311 !

@kb-0311
Copy link
Contributor Author

kb-0311 commented Apr 1, 2022

Thanks for clearing that up @obulat!

The only outdated dev dependencies which I will be updating in the next PR are the ones dealing with testing.

After that is done we can probably close the issue.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kb-0311!

@krysal krysal changed the title updates @intlify/eslint-plugin-vue-i18n , vue-tsc lint-staged Update @intlify/eslint-plugin-vue-i18n, vue-tsc & lint-staged Apr 1, 2022
@krysal krysal merged commit a7bfcb9 into WordPress:main Apr 1, 2022
@zackkrida zackkrida added 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated dependencies
5 participants