Content page component design fixes

[obulat]

Fixes

Fixes #1090 by @zackkrida

Description

This PR attempts to finish up the work started in #1093 to get it merged :)
It merges main and applies the following #1093 code review suggestions:

On desktop

• Margin bottom of h1 set to 40px.
• Margin top of h3 set to 40px.
• Links in main content only have an underline style on hover.
• In the table, labels in header cells are description bold style.
• In the table, texts in cells are description regular style.
• External icon in main CTA in sources uses correct icon.

On mobile

• h1, h3 styles updated

The following suggestions were not implemented:

• Mobile paragraph styles not updated.
• The table layout on mobile is unchanged.

Other changes:

• scss removed from the pages styles
• VContentPage name added so that it can be imported in the components.

Testing Instructions

Check that the content pages look similar to the Sources page mockup, and are not broken.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[zackkrida]

Wow, thanks! I changed the base branch to main, otherwise there were 392 files to review 😅 . We can just merge this as a replacement to #1093 I think.

The changes look perfect to me; LGTM!

[sarayourfriend]

Tested locally and looks good to me. One question before approving but otherwise looks good.

[zackkrida]

@sarayourfriend could you re-review this one before your time off? seems like a quick win.

[sarayourfriend]

This massive list of prose-* classes also scares me. It has all the features of the worst parts of Tailwind IMO (namely, a super long and inscrutable list of class names that are difficult to edit, read, and get a full picture of).

Adding our own prose class to tailwind.css with these styles using the @apply rule would probably be easier to read and maintain 🤷 Just my own feeling about this plugin though.

[sarayourfriend]

The pages LGTM. I don't really like the plugin but I can see that it makes things easier here in some sense (though IMO harder long term) so I won't block on it.

[zackkrida]

@sarayourfriend the primary reason I'd like to use the plugin is so we have more raw html tags in use and can easily replace things, like <h1> ~> <Heading level="1"> or whatever if and when we make our design system more robust, instead of having to do a bunch of manual work or, god forbid, regex matching on html tags with classes and other attributes. Your thoughts are well-received!