Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Create component to wrap content pages #1093

Closed
wants to merge 2 commits into from
Closed

Conversation

zackkrida
Copy link
Member

Fixes

Fixes #1090 by @zackkrida

Description

This PR creates a VContentPage component, that simply applies some styles to raw html tags that are its children. It also matches the body font size of these pages and the content width to better match the mockups.

Testing Instructions

View the standalone content pages, like /about and /sources, and observe that they look correct. This is a little subjective since the styles for these pages aren't the most defined, so use your judgement and please point out if something doesn't look good.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner March 9, 2022 21:25
@zackkrida zackkrida requested review from krysal and obulat March 9, 2022 21:25
@dhruvkb dhruvkb added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed labels Mar 9, 2022
<template>
<div class="pt-5 md:pt-10" dir="ltr">
<div
class="px-6 lg:px-0 mb-10 lg:mb-30 md:max-w-4xl xl:max-w-5xl prose prose-sm md:prose-base mx-auto max-w-none prose-a:text-pink prose-headings:font-bold lg:prose-headings:text-3xl lg:prose-h1:text-6xl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set the width a little smaller? Something closer to the '70 to 80 characters per line (about 8 to 10 words in English)' that is usually suggested for comfortable reading?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's much smaller than the current width of these pages, but maybe we could go even smaller. @panchovm could you look at this PR this week?

@@ -11,11 +11,4 @@ a > em {
font-weight: 600;
}

.table {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to move the rest of this file to tailwind.css base layer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the em tag is being used incorrectly here, so perhaps better to just remove these. I'll look into it!

@fcoveram
Copy link

The main styles look correct on desktop, but not sure how deep is the comparison I need to do. Nonetheless, I noted the following:

On desktop

  1. Margin bottom of h1 looks too small, it should be 40px.
  2. Margin top of h3 looks too small, it should be 40px.
  3. Links in main content have an underline style in resting state. It should show the underline in hover, as the source table items.
  4. In the table, labels in header cells should be description bold style.
  5. In the table, texts in cells should be description regular style.
  6. External icon in main CTA is incorrect, it should be the WordPress Design Library one.

On mobile

  1. h1, h3, and paragraphs do not follow the style change as defined in mockups.
  2. The table proposed has a different layout where table header is in a left column and data in a right column.

None of the observations noted above are blockers. Feel free to narrow the ticket scope and work on the suggestions in a different PR.

@obulat obulat mentioned this pull request Mar 23, 2022
7 tasks
@zackkrida
Copy link
Member Author

Closing in favor of #1172

@zackkrida zackkrida closed this Mar 23, 2022
@obulat obulat mentioned this pull request Oct 24, 2022
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create VContentPage component
5 participants