-
Notifications
You must be signed in to change notification settings - Fork 63
Create component to wrap content pages #1093
Conversation
<template> | ||
<div class="pt-5 md:pt-10" dir="ltr"> | ||
<div | ||
class="px-6 lg:px-0 mb-10 lg:mb-30 md:max-w-4xl xl:max-w-5xl prose prose-sm md:prose-base mx-auto max-w-none prose-a:text-pink prose-headings:font-bold lg:prose-headings:text-3xl lg:prose-h1:text-6xl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set the width a little smaller? Something closer to the '70 to 80 characters per line (about 8 to 10 words in English)' that is usually suggested for comfortable reading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's much smaller than the current width of these pages, but maybe we could go even smaller. @panchovm could you look at this PR this week?
@@ -11,11 +11,4 @@ a > em { | |||
font-weight: 600; | |||
} | |||
|
|||
.table { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to move the rest of this file to tailwind.css
base layer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the em
tag is being used incorrectly here, so perhaps better to just remove these. I'll look into it!
The main styles look correct on desktop, but not sure how deep is the comparison I need to do. Nonetheless, I noted the following: On desktop
On mobile
None of the observations noted above are blockers. Feel free to narrow the ticket scope and work on the suggestions in a different PR. |
Closing in favor of #1172 |
Fixes
Fixes #1090 by @zackkrida
Description
This PR creates a
VContentPage
component, that simply applies some styles to raw html tags that are its children. It also matches the body font size of these pages and the content width to better match the mockups.Testing Instructions
View the standalone content pages, like
/about
and/sources
, and observe that they look correct. This is a little subjective since the styles for these pages aren't the most defined, so use your judgement and please point out if something doesn't look good.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin